feat(watchtower): move watchtower tests to new testnet#1846
Merged
Conversation
caglaryucekaya
changed the title
caglaryucekaya
changed the title
caglaryucekaya
changed the title
…und_erc20_payment tests
onur-ozkan
previously approved these changes
Jun 13, 2023
onur-ozkan
left a comment
onur-ozkan
left a comment
There was a problem hiding this comment.
only couple non-blocker suggestions
|
|
||
| fn is_supported_by_watchers(&self) -> bool { | ||
| false | ||
| std::env::var("USE_WATCHER_REWARD").is_ok() |
There was a problem hiding this comment.
Can we use coins configuration instead of re-fetching the environment?
Author
There was a problem hiding this comment.
I did this to enable watcher rewards in certain tests and disable in others temporarily. Soon I will implement watcher rewards as an option for orders and there won't be need for this anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
send_and_refund_eth_payment,send_and_refund_erc20_payment,test_nonce_lockandtest_withdraw_and_sendtests that were failing due to concurrency