feat(adex-cli): enable, get-enabled, orderbook, sell, buy provided by rozhkovdmitrii · Pull Request #1768 · GLEECBTC/komodo-defi-framework

rozhkovdmitrii · 2023-04-25T10:18:40Z

This PR introduces new commands that adex-cli supports:

enable
get-enabled
orderbook
sell
buy

`adex-cli` Dependency Updates:

Updated:

				mm2 Cargo.lock
`clap`	`2.34.0`	->	`4.2.7`	`2.33.0`
`hashbrown`	`0.9.1`	->	`0.12.3`	`0.11.2`,`0.12.1`,`0.13.2`
`hashlink`	`0.6.0`	->	`0.8.3`	`0.8.2`
`strsim`	`0.8.0`	->	`0.10.0`	`0.8.0`
`wasm-bindgen`	`0.2.80`	->	`0.2.87`	`0.2.86`
`wasm-bindgen-backend`	`0.2.80`	->	`0.2.87`	`0.2.86`
`wasm-bindgen-macro`	`0.2.80`	->	`0.2.87`	`0.2.86`
`wasm-bindgen-macro-support`	`0.2.80`	->	`0.2.87`	`0.2.86`
`wasm-bindgen-shared`	`0.2.80`	->	`0.2.87`	`0.2.86`

New:

		mm2 Cargo.lock
`allocator-api2`	`0.2.15`
`anstream`	`0.3.2`
`anstyle`	`1.0.0`
`anstyle-parse`	`0.2.0`
`anstyle-query`	`1.0.0`
`anstyle-wincon`	`1.0.1`
`arrayvec`	`0.5.2`	`0.5.1`,`0.7.1`
`bigdecimal`	`0.3.1`	`0.3.0`
`blake2b_simd`	`0.5.11`	`0.5.10`
`clap_builder`	`4.2.7`
`clap_derive`	`4.2.0`
`colorchoice`	`1.0.0`
`directories`	`5.0.1`	`3.0.2`
`dirs-sys`	`0.4.1`	`0.3.6`
`errno`	`0.3.1`	`0.2.8`
`hashbrown`	`0.14.0`	`0.11.2`,`0.12.1`,`0.13.2`
`heck`	`0.4.1`	`0.4.0`
`hermit-abi`	`0.3.1`	`0.1.14`
`io-lifetimes`	`1.0.11`	`1.0.6`
`is-terminal`	`0.4.7`
`keccak`	`0.1.4`	`0.1.0`
`linux-raw-sys`	`0.3.8`	`0.1.4`
`num-rational`	`0.4.1`	`0.4.0`
`option-ext`	`0.2.0`
`paste`	`1.0.12`	`1.0.7`
`portable-atomic`	`1.3.3`	`1.3.2`
`redox_users`	`0.4.3`	`0.3.4`, `0.4.0`
`rustix`	`0.37.20`	`0.36.9`
`utf8parse`	`0.2.1`

mm2src/mm2_rpc/src/legacy.rs

mm2src/mm2_main/src/lp_ordermatch.rs

mm2src/mm2_libp2p/src/atomicdex_behaviour/tests.rs

mm2src/mm2_bin_lib/src/mm2_wasm_lib.rs

mm2src/coins/utxo/utxo_builder/utxo_coin_builder.rs

mm2src/mm2_main/src/lp_ordermatch.rs

onur-ozkan · 2023-05-08T09:17:29Z

Can you update the PR description what this pr resolves and whats it's exact goal? That will help us to review the PR

shamardy

Thank you for the amazing work!
The PR is quite big so I will do this review in multiple small iterations to try to cover as much of the code as I can by the end. Only a few suggestions and opening some points to discussion at this stage of the review.

mm2src/mm2_rpc/src/legacy.rs

mm2src/adex_cli/src/adex_proc/smart_fraction_fmt.rs

mm2src/adex_cli/src/adex_app.rs

mm2src/adex_cli/src/adex_proc/adex_proc.rs

shamardy

Next review iteration! I finished reviewing all code changes unrelated to adex_cli.
Please also merge with latest dev.

mm2src/adex_cli/Cargo.lock

mm2src/mm2_rpc/src/data/legacy.rs

mm2src/common/io.rs

mm2src/mm2_rpc/src/data/legacy.rs

mm2src/mm2_main/src/rpc/lp_commands/lp_commands_legacy.rs

mm2src/mm2_rpc/Cargo.toml

# Conflicts: # mm2src/mm2_main/src/lp_ordermatch.rs # mm2src/mm2_main/src/lp_ordermatch/best_orders.rs # mm2src/mm2_main/src/lp_ordermatch/orderbook_rpc.rs # mm2src/mm2_main/tests/docker_tests/docker_tests_common.rs # mm2src/mm2_main/tests/mm2_tests/best_orders_tests.rs

…_coins.rs`

…to()`

…s `json`

…tated

onur-ozkan

Last review iteration from my side:

mm2src/mm2_rpc/Cargo.toml

mm2src/mm2_main/src/rpc/lp_commands/lp_commands_legacy.rs

mm2src/mm2_main/src/ordermatch_tests.rs

mm2src/common/io.rs

# Conflicts: # mm2src/mm2_main/src/lp_swap/taker_swap.rs # mm2src/mm2_main/tests/mm2_tests/iris_swap.rs

shamardy

Thanks a lot for your patience with the fixes! LGTM! Only 2 minor non-blockers.

mm2src/adex_cli/src/cli.rs

mm2src/adex_cli/src/adex_proc/response_handler.rs

shamardy

Re-approve

rozhkovdmitrii added the in progress label Apr 25, 2023

rozhkovdmitrii force-pushed the feature-1682-interoperating branch 6 times, most recently from f59ead6 to f2622c9 Compare May 2, 2023 08:09