Skip to content

build linux x86-64 with reasonable glibc #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shamardy merged 6 commits into from
Mar 24, 2023
Merged

build linux x86-64 with reasonable glibc #1733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23beaac
use `ubuntu-18.04` for dev and release builds
onur-ozkan Mar 24, 2023
0249d00
always cancel previous `in-progress` pipelines when new commit pushed
onur-ozkan Mar 24, 2023
86daf56
switch from `ubuntu-latest` to `ubuntu-18.04` for all builds
onur-ozkan Mar 24, 2023
8a5d270
turn off share generics nightly feature
onur-ozkan Mar 24, 2023
43b8d71
set JEMALLOC environments in CI
onur-ozkan Mar 24, 2023
cacc706
rollback jemalloc entry from changelog
onur-ozkan Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cargo/config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[env]
JEMALLOC_SYS_WITH_MALLOC_CONF = "percpu_arena:percpu,oversize_threshold:0,background_thread:true,metadata_thp:auto,dirty_decay_ms:5000,muzzy_decay_ms:5000"
JEMALLOC_SYS_WITH_MALLOC_CONF = "background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,metadata_thp:auto"

[target.'cfg(all())']
rustflags = [ "-Zshare-generics=y" ]
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/dev-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,19 @@ on:
branches:
- dev

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
MANUAL_MM_VERSION: true
JEMALLOC_SYS_WITH_MALLOC_CONF: 'background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,metadata_thp:auto'

jobs:
linux-x86-64:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -193,7 +198,7 @@ jobs:

wasm:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -281,7 +286,7 @@ jobs:

android-aarch64:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -329,7 +334,7 @@ jobs:

android-armv7:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -380,7 +385,7 @@ jobs:
if: github.event_name != 'pull_request'
needs: linux-x86-64
timeout-minutes: 15
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v2

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/fmt-and-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
- main
- dev

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
fmt-and-lint:
timeout-minutes: 45
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,19 @@ on:
branches:
- main

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
MANUAL_MM_VERSION: true
JEMALLOC_SYS_WITH_MALLOC_CONF: 'background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,metadata_thp:auto'

jobs:
linux-x86-64:
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -188,7 +193,7 @@ jobs:

wasm:
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -276,7 +281,7 @@ jobs:

android-aarch64:
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -324,7 +329,7 @@ jobs:

android-armv7:
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
- main
- dev

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
FROM_SHARED_RUNNER: true

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/virustotal_scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
release:
types: [created, edited, released, published]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
virustotal:
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
- CI/CD migrated from Azure to Github runners [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- CI tests are much stabilized [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- Integration and unit tests are seperated on CI stack [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- Jemalloc configuration updated for optimization purposes [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- Codebase is updated in linting rules at wasm and test stack [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- `crossbeam` bumped to `0.8` from `0.7` [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- Un-used/Unstable parts of mm2 excluded from build outputs which avoids mm2 runtime from potential UB [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
Expand Down