Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions azure-pipelines-build-stage-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
condition: and( eq( variables['Agent.OS'], 'Linux' ), eq( variables['Build.SourceBranchName'], 'dev' ) )
displayName: 'Update playground deployment'
# Explicit --test-threads=16 makes testing process slightly faster on agents that have <16 CPU cores.
# Always run tests on mm2.1 branch and PRs
# Always run tests on main branch and PRs
# On MacOS, run for x86_64-apple-darwin
- bash: |
if [ $AGENT_OS = "Darwin" ]
Expand All @@ -94,7 +94,7 @@ jobs:
TELEGRAM_API_KEY: $(${{ parameters.telegram_api_key }})
RUST_LOG: debug
MANUAL_MM_VERSION: true
condition: or( eq( variables['Build.Reason'], 'PullRequest' ), eq( variables['Build.SourceBranchName'], 'mm2.1' ), eq( variables['Build.SourceBranchName'], 'dev' ) )
condition: or( eq( variables['Build.Reason'], 'PullRequest' ), eq( variables['Build.SourceBranchName'], 'main' ), eq( variables['Build.SourceBranchName'], 'dev' ) )
- bash: |
containers=$(docker ps -q | wc -l)
echo $containers
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines-wasm-stage-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
BOB_PASSPHRASE: $(${{ parameters.bob_passphrase }})
ALICE_PASSPHRASE: $(${{ parameters.alice_passphrase }})
MANUAL_MM_VERSION: true
condition: or( eq( variables['Build.Reason'], 'PullRequest' ), eq( variables['Build.SourceBranchName'], 'mm2.1' ), eq( variables['Build.SourceBranchName'], 'dev' ) )
condition: or( eq( variables['Build.Reason'], 'PullRequest' ), eq( variables['Build.SourceBranchName'], 'main' ), eq( variables['Build.SourceBranchName'], 'dev' ) )
- bash: |
cd target/target-wasm-release/
zip ../../upload/mm2-$(COMMIT_HASH)-$(Agent.OS)-Wasm-Release mm2lib_bg.wasm mm2lib.js snippets -r
Expand Down
34 changes: 17 additions & 17 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ stages:
name: 'MM2_Lint_Linux'
os: 'Linux'

- template: azure-pipelines-lint-stage-job.yml # Template reference
parameters:
name: 'MM2_Lint_MacOS'
os: 'Darwin'
# - template: azure-pipelines-lint-stage-job.yml # Template reference
# parameters:
# name: 'MM2_Lint_MacOS'
# os: 'Darwin'

- template: azure-pipelines-lint-stage-job.yml # Template reference
parameters:
Expand All @@ -67,14 +67,14 @@ stages:

- stage: Mobile
displayName: Mobile libs build
condition: and(succeeded('WASM'), or(eq(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.SourceBranchName'], 'mm2.1'), eq(variables['Build.SourceBranchName'], 'dev')))
condition: and(succeeded('WASM'), or(eq(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.SourceBranchName'], 'main'), eq(variables['Build.SourceBranchName'], 'dev')))
jobs:
- template: azure-pipelines-android-job.yml
parameters:
os: 'Linux'
- template: azure-pipelines-ios-job.yml
parameters:
os: 'Darwin'
# - template: azure-pipelines-ios-job.yml
# parameters:
# os: 'Darwin'

- stage: Desktop
displayName: Desktop Build and test
Expand All @@ -91,15 +91,15 @@ stages:
alice_userpass: 'ALICE_USERPASS_LINUX'
telegram_api_key: 'TELEGRAM_API_KEY'

- template: azure-pipelines-build-stage-job.yml # Template reference
parameters:
name: 'MM2_Build_MacOS'
os: 'Darwin'
bob_passphrase: 'BOB_PASSPHRASE_MAC'
bob_userpass: 'BOB_USERPASS_MAC'
alice_passphrase: 'ALICE_PASSPHRASE_MAC'
alice_userpass: 'ALICE_USERPASS_MAC'
telegram_api_key: 'TELEGRAM_API_KEY'
# - template: azure-pipelines-build-stage-job.yml # Template reference
# parameters:
# name: 'MM2_Build_MacOS'
# os: 'Darwin'
# bob_passphrase: 'BOB_PASSPHRASE_MAC'
# bob_userpass: 'BOB_USERPASS_MAC'
# alice_passphrase: 'ALICE_PASSPHRASE_MAC'
# alice_userpass: 'ALICE_USERPASS_MAC'
# telegram_api_key: 'TELEGRAM_API_KEY'

- template: azure-pipelines-build-stage-job.yml # Template reference
parameters:
Expand Down
12 changes: 6 additions & 6 deletions docs/GIT_FLOW_AND_WORKING_PROCESS.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Git flow

1. There are two permanent branches: mm2.1 (master/release) and dev.
2. The goal is to have both mm2.1 and dev ready to be released at any point in time - all auto-tests pass, no incompatibilities introduced, etc.
3. The dev is merged to mm2.1 when a new release is planned.
1. There are two permanent branches: main (master/release) and dev.
2. The goal is to have both main and dev ready to be released at any point in time - all auto-tests pass, no incompatibilities introduced, etc.
3. The dev is merged to main when a new release is planned.
4. The feature branch lifetime should be <= 1-2 weeks.
5. Big task should be decomposed to the several feature branches. Each of which is merged periodically with a code review process. The new feature branch should be started from dev afterward.
6. In certain cases, the dev might not be in a "releasable" state. In this case, if the feature branch has no dependencies updates, it might be merged directly to mm2.1 if required (hotfix, very useful feature, blocker). Dev is synced with mm2.1 afterward.
6. In certain cases, the dev might not be in a "releasable" state. In this case, if the feature branch has no dependencies updates, it might be merged directly to main if required (hotfix, very useful feature, blocker). Dev is synced with main afterward.
7. For convenience, we can consider making several minor features/fixes in the single feature branch.

Pros:
Expand All @@ -20,10 +20,10 @@ Cons:

1. It's desired to have a separate issue for any bug report or feature request.
2. Once the issue is created, add it to the MM2.0 Github project. Select an appropriate column.
3. Decide whether you should base your feature branch on mm2.1 or dev. For hotfixes or minor useful features that don't include any dependencies updates choose mm2.1. In other cases choose dev.
3. Decide whether you should base your feature branch on main or dev. For hotfixes or minor useful features that don't include any dependencies updates choose main. In other cases choose dev.
5. PR titles must have a prefix that displays the current status of PR. Such as `[wip] X feat integration`, `[r2r] X feat integration`, where `[wip]` prefix stands for "Work in Progress", and `[r2r]` for Ready to Review.
4. PRs to dev can be merged right after approval. Request the tests in the dev branch from Tony by assigning the issue to him and moving it to the `Testing` column. Provide a detailed explanation of what changed and what should be tested. Indicate the critical points.
5. PRs to mm2.1 must be tested by QA *before* merging.
5. PRs to main must be tested by QA *before* merging.
6. If documentation update is required, prepare examples and notify smk762. Assign issue to him. Move the issue to the documentation column. Smk will then prepare PR in [developer-docs](https://github.com/KomodoPlatform/developer-docs) repo.
7. Review the docs PR. Smk will request it from the feature implementor.

Expand Down
2 changes: 1 addition & 1 deletion docs/PR_REVIEW_CHECKLIST.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ the test is unstable, please clarify it with the team.
- [ ] Indicate code that is worth moving to a separate module or crate.
- [ ] Check if the code can be improved/simplified: it might be overly abstracted or require the additional abstraction layer instead for a better design.
- [ ] Follow SOLID if applicable.
- [ ] For PRs targeting release (mm2.1) branch check that QA tested and approved it.
- [ ] For PRs targeting release (main) branch check that QA tested and approved it.
4 changes: 2 additions & 2 deletions mm2src/coins/eth/eth_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ fn test_wait_for_payment_spend_timeout() {

#[test]
#[ignore]
/// Ignored temporarily until dev is merged to mm2.1
/// Ignored temporarily until dev is merged to main
fn test_search_for_swap_tx_spend_was_spent() {
let key_pair = KeyPair::from_secret_slice(
&hex::decode("809465b17d0a4ddb3e4c69e8f23c2cabad868f51f8bed5c765ad1d6516c3306f").unwrap(),
Expand Down Expand Up @@ -594,7 +594,7 @@ fn test_gas_station() {

#[test]
#[ignore]
/// Ignored temporarily until dev is merged to mm2.1
/// Ignored temporarily until dev is merged to main
fn test_search_for_swap_tx_spend_was_refunded() {
let key_pair = KeyPair::from_secret_slice(
&hex::decode("809465b17d0a4ddb3e4c69e8f23c2cabad868f51f8bed5c765ad1d6516c3306f").unwrap(),
Expand Down