[r2r] lock free avoid on account sequence problems#1694
Merged
Conversation
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
…ck-free-sequence-logic
shamardy
reviewed
Mar 6, 2023
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
Thank you for the fix! A few minor suggestions.
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
lock-free-sequence-logic
branch
from
952ae02 to
4334746
Compare
onur-ozkan
force-pushed
the
lock-free-sequence-logic
branch
from
4008284 to
4334746
Compare
…ck-free-sequence-logic Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
lock-free-sequence-logic
branch
from
21c19de to
da58257
Compare
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
lock-free-sequence-logic
branch
from
fdba177 to
e253d07
Compare
ca333
approved these changes
Mar 14, 2023
shamardy
added a commit
that referenced
this pull request
Mar 14, 2023
shamardy
added a commit
that referenced
this pull request
Mar 14, 2023
* add change logs for PRs merged to dev only
* remove {version} - {date} and add dev branch instead
* add ibc transfer change logs
* add lightning PR #1655 to change logs
* add changelog for #1706
* add changelog for #1694, #1665
---------
Reviewed-by: laruh, caglaryucekaya <caglaryucekaya@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, even we have using mutex to lock concurrency in mm2 instance for tendermint operations, it's still possible to get sequence issues by running multiple instances. Because the lock is on the application level not distributed one, there is no way to handle sequence problems which might fail transactions like in the swap tests.
The only way to overcome this problem is looping over the requests if there is an account sequence problem. And thats what this PR provides in a lock-free way.
Also resolves #1691 and #1569