[r2r] IndexedDB Cursor Iterator#1678
Merged
shamardy merged 7 commits intoGLEECBTC:devfrom Mar 7, 2023
Merged
Conversation
* Add `CursorIter::next` * Add `IdbEmptyCursor`
* Make `height: BeBigUint` instead of `u64` * Fix `BlockHeaderStorageTable::TICKER_HEIGHT_INDEX` index
borngraced
reviewed
Feb 28, 2023
borngraced
previously approved these changes
Feb 28, 2023
borngraced
left a comment
borngraced
left a comment
There was a problem hiding this comment.
great work and very clear to me! thanks
shamardy
previously approved these changes
Feb 28, 2023
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
Great enhancement! Only non-blockers
sergeyboyko0791
dismissed stale reviews from shamardy and borngraced
via
d8bc96c
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1643
IDBBlockHeadersStorage