Conversation
- Add CoinDetailsBalanceConfirmationController to confirm balance before showing amounts - Extend withdraw form BLoC/state/events and coin details UI integration - Improve coins repo/state USD conversion; update rewards and transaction views - Add unit tests for balance confirmation and coins USD conversion
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1377801565
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Visit the preview URL for this PR (updated for commit eee9e36): https://walletrc--pull-3465-merge-kr4iz565.web.app (expires Fri, 03 Apr 2026 16:42:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb63faa0d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Refactor the withdraw confirmation screen into card-based sections (summary, destination, TRON details) with responsive layouts, status banners for expiration/refresh state, and a dedicated success receipt replacing the reused TransactionDetails widget.
CharlVS
changed the title
…widget Use the live bloc state instead of the stale requestState snapshot when emitting the Trezor confirmation flag in _generatePreview, preventing isSending/isPreviewRefreshing from being reset mid-request. Add didUpdateWidget to _BalanceState so the confirmation controller and balance stream are torn down and re-bound when the parent supplies a different coin without remounting the widget.
Move isAwaitingTrezorConfirmation into the callers' own "in progress" emits (from requestState.copyWith) instead of emitting from the live bloc state getter inside _generatePreview. This keeps all emissions consistent with the explicit requestState snapshot pattern and makes _generatePreview a pure function with no side effects.
Add transactions and addresses chips to the coin details header so users can jump directly to those sections without scanning the full page.
Keep section scroll keys in the coin details state and pass semantic callbacks to child widgets so the shortcut chips depend on actions rather than scroll implementation details.
CharlVS
changed the title
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcc0ebfd19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Preserve unrelated async updates while discarding preview results and errors once the effective withdraw request changes.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52bd3a183d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add comprehensive coin-details unit/BLoC and widget coverage, plus integration scenarios and aggregate test wiring, so regressions in withdraw, transaction details, rewards, and faucet/address flows are caught earlier.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 259517e868
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Schedule bounded startup retries when bootstrap fetch fails so coin-details balance confirmation does not remain stuck unconfirmed when the stream is quiet.
Includes merged PR #342: RPC method hint for ambiguous KDF error parsing.
…splay Add formatKdfUserFacingError and extractKdfTechnicalDetails (MmRpc, GeneralErrorResponse, SdkError, activation wrappers). Use across withdraw, coin addresses, transaction history, bridge/taker fee and preimage paths, profit/loss and portfolio growth failures, and ARRR activation emit errors. Drop redundant English prefixes where the underlying error is already specific. Update withdraw_form_bloc tests.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
getBalancecheck or a qualifying stream update, preventing stale cached values from showing.isFeePriceExpensive), improved error handling during confirm step, and new events/state fields for the richer UX.WithdrawSuccessReceiptreplacing the reusedTransactionDetailswidget.coins_repo/coins_stateto avoid null/stale values.Test Coverage Added (new)
withdraw_form_bloc_test.dartwith stale-preview, refresh-recovery, max-amount recompute, duplicate-submit, and SDK error mapping cases.test_coin_details_core.darttest_coin_details_rewards.darttest_units/main.dartaggregate execution path.Changed files
lib/views/wallet/coin_details/transactions/transaction_details.darttest_units/main.darttest_units/tests/wallet/coin_details/*test_integration/tests/wallets_tests/test_withdraw.darttest_integration/tests/wallets_tests/test_coin_details_core.darttest_integration/tests/wallets_tests/test_coin_details_rewards.dartTesting
dart formaton all changed Dart files.flutter analyzeon touched paths (no issues).flutter test test_units/tests/wallet/coin_details(passes).MissingPluginExceptionforshared_preferences), so they are included but not green locally under this runner.