fix(wallet): preserve charts, improve TRON UX, and roll SDK#3462
Merged
fix(wallet): preserve charts, improve TRON UX, and roll SDK#3462
Conversation
Use restartable handling for period changes, skip stale periodic refresh cycles when the selected range changes mid-flight, filter chart samples to the visible window with a leading boundary point, and key the line chart by selected period so Flutter rebuilds the series correctly.
- Extract computeWalletTotalUsd with docs on CEX vs SDK price sources - CoinsBloc/CoinsRepo: defensive unmodifiable price maps, uppercase keys - Coin details: watchBalance stream; balancePlaceholder for unknown values - Export ThemeCustomDark/Light from app_theme to fix implementation_imports - Add unit tests for computeWalletTotalUsd; add code review notes doc
Dartify may return int or double from JS; use num.toInt() for stable returns.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…ix/profit-loss-chart-sdk-market
|
Visit the preview URL for this PR (updated for commit b9eb4ad): https://walletrc--pull-3462-merge-aalivb0n.web.app (expires Wed, 01 Apr 2026 00:10:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
- WithdrawFormStepReverted: from confirm, go to fill and clear preview/previewError/transactionError\n- Coins without tx history: open explorer with showAddressSearch when multiple addresses
Add dedicated GRC20 enum variant and mappings instead of aliasing to ERC20, and move TRX/TRC20 into the supported transaction-history list so the wallet displays TRON transactions.
Update the sdk submodule pointer to the merged dev commit for TRON transaction history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdksubmodule to mergedorigin/devcommitec8e714for the TRON explorer URL fixdevIncluded branch history ahead of
devfix(wallet): launch TRON explorer URLs correctlyfix(wallet): preserve charts, improve TRON UX, and roll SDKValidation
dart formaton the modified Dart filesflutter analyzeon the modified Dart files: no issues foundflutter analyzerepo-wide: completes with the existing analyzer backlog in the repo/submodule tree (2091 issues), no new targeted-file issues surfaced