Skip to content

fix(search): preserve list search focus across rebuilds#3451

Merged
CharlVS merged 2 commits intodevfrom
fix/search-focus-rebuilds
Mar 21, 2026
Merged

fix(search): preserve list search focus across rebuilds#3451
CharlVS merged 2 commits intodevfrom
fix/search-focus-rebuilds

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Mar 20, 2026

Summary

  • preserve search focus and cursor state across rebuilds in wallet assets, coins manager, bridge ticker list, DEX coin filters, and NFT desktop filters
  • move controller and focus ownership to stable parents so filtered-list updates do not recreate editing state
  • keep existing debounce timings, filter behavior, and widget keys unchanged

Validation

  • reviewed lifecycle and bloc sync paths for focus regressions and feedback loops
  • ran dart format on the touched files
  • ran targeted flutter analyze on the changed files with no issues found
  • did not run unit or integration tests because repository guidance states they are currently failing globally; validated through static analysis and code review

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

Visit the preview URL for this PR (updated for commit b8f81ba):

https://walletrc--pull-3451-merge-d8rrq9xv.web.app

(expires Sat, 28 Mar 2026 17:18:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@CharlVS CharlVS force-pushed the fix/search-focus-rebuilds branch from c90509d to a68fff5 Compare March 21, 2026 14:19
@CharlVS CharlVS changed the title fix: preserve search focus across rebuilds fix(search): preserve list search focus across rebuilds Mar 21, 2026
@CharlVS CharlVS force-pushed the fix/search-focus-rebuilds branch from 7d0a50c to 1a4ee97 Compare March 21, 2026 15:48
@CharlVS CharlVS merged commit fa1e14a into dev Mar 21, 2026
4 of 11 checks passed
@CharlVS CharlVS deleted the fix/search-focus-rebuilds branch March 21, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant