feat(wallet): roll SDK and complete TRON integration#3446
Conversation
|
Visit the preview URL for this PR (updated for commit a54ad91): https://walletrc--pull-3446-merge-ru0wzdhb.web.app (expires Wed, 25 Mar 2026 19:44:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
There was a problem hiding this comment.
💡 Codex Review
When the user selects TRC20, this call sends the parent asset ID into the repository, and the repository derives all protocol behavior from networkId.subClass (fetchCustomToken / _createNewCoin). Because this commit split TRON into CoinSubClass.trx and CoinSubClass.trc20, the repo will now see the native trx subclass instead of trc20, so it uses TRX address/token-info semantics and never enters the new CoinSubClass.trc20 protocol branch. In practice, custom TRC20 imports will fail or build the wrong asset metadata.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 184a4ccc9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
For newly supported TRC20 imports, the created asset reuses platformAsset.id.chainId, so the token inherits TRX’s decimals instead of the response.info.decimals returned by getTokenInfo(). Downstream code like Asset.toCoin() and withdraw amount formatting read asset.id.chainId.decimals, so any TRC20 token that is not 6-decimal will display balances and send amounts at the wrong scale after import.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Preserve native TRX fiat support, send Ramp TRON asset codes correctly, and keep imported TRC20 token decimals aligned with token metadata.
|
Addressed the remaining Codex review items:
Also added focused regression coverage and re-ran |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57a221dd31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9246a495fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep previously saved parent/token metadata intact when a custom-token preview is cancelled, while still fully rolling back preview-only activations.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
origin/devTRON support commitTRXandTRC20assets resolve to the correct wallet asset IDsValidation
dart formaton the touched filesflutter analyzeon the changed TRON-related files