feat: polish trading and responsive ui surfaces#3443
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 455814ff48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (final option in options.skip(1)) { | ||
| final int diff = (option.seconds - seconds).abs(); | ||
| if (diff < closestDiff) { | ||
| closest = option; | ||
| closestDiff = diff; |
There was a problem hiding this comment.
fromString now rounds any parsed value to the nearest enum option, which silently rewrites valid non-enum bot intervals (for example, a stored price_elapsed_validity of 1200 seconds becomes 900). Because edit flows read TradeCoinPairConfig.updateInterval and then save back the enum-derived seconds, users can change bot behavior without touching this field; this should keep exact values (or explicitly mark unsupported ones) instead of nearest rounding.
Useful? React with 👍 / 👎.
|
Visit the preview URL for this PR (updated for commit 455814f): https://walletrc--pull-3443-merge-uk0jhxb3.web.app (expires Thu, 19 Mar 2026 14:52:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
1 participant
Replacement for ineffective merge of #3437 (merged with empty diff after branch reset during conflict handling).