feat: polish wallet workflows and settings#3442
Conversation
|
Visit the preview URL for this PR (updated for commit e3f126e): https://walletrc--dev-preview-wmjfkfhs.web.app (expires Thu, 19 Mar 2026 14:31:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3f126e89a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| initialDelay: const Duration(seconds: 5), | ||
| maxDelay: const Duration(seconds: 30), | ||
| ), | ||
| shouldRetry: (error) => error is _RetryableZhtlcActivationException, |
There was a problem hiding this comment.
shouldRetry now only permits _RetryableZhtlcActivationException, so any other exception coming from _sdk.assets.activateAsset(...) (for example transient transport/RPC errors) will bypass the retry loop and fail after a single attempt despite maxAttempts and backoff being configured. This is a reliability regression in ARRR activation flows because recoverable runtime errors are no longer retried.
Useful? React with 👍 / 👎.
| final stored = await settingsRepository.loadSettings(); | ||
| final settings = stored.marketMakerBotSettings.copyWith( | ||
| isMMBotEnabled: value, |
There was a problem hiding this comment.
This handler reloads settings from storage before constructing the updated MarketMakerBotSettings; if two toggles are changed close together, one callback can read stale persisted data and dispatch an event that overwrites the other change. For example, toggling bot enablement and save-orders in quick succession can revert one flag because each callback copies from an out-of-date snapshot instead of current SettingsBloc state.
Useful? React with 👍 / 👎.
1 participant
Replacement for auto-closed #3435 (closed when its base branch was deleted during sequential squash merges).