Skip to content

removes timer on password visibility#3388

Merged
smk762 merged 2 commits intodevfrom
chore/no-timer-on-passwd-vis
Nov 23, 2025
Merged

removes timer on password visibility#3388
smk762 merged 2 commits intodevfrom
chore/no-timer-on-passwd-vis

Conversation

@smk762
Copy link
Copy Markdown
Collaborator

@smk762 smk762 commented Nov 12, 2025

Closes #2959

To test:
Check all password fields in app. Ensure toggling visibility to see the input chars does not automatically hide after a few seconds.

  • wallet create create
  • wallet import form
  • change password form
  • view private keys form
  • view mnemonic form
  • delete wallet form
  • wallet login form

@smk762 smk762 self-assigned this Nov 12, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/no-timer-on-passwd-vis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@smk762 smk762 linked an issue Nov 12, 2025 that may be closed by this pull request
@smk762 smk762 requested a review from mariocynicys November 12, 2025 07:37
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 12, 2025

Visit the preview URL for this PR (updated for commit 1b6e4af):

https://walletrc--pull-3388-merge-cunn095y.web.app

(expires Sun, 30 Nov 2025 08:03:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

Copy link
Copy Markdown

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected.
Thanks

@smk762 smk762 merged commit e117548 into dev Nov 23, 2025
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make password peek timeout-less

2 participants