Skip to content

fix(ios): fix download logs dialog not opening on iOS#3374

Merged
ca333 merged 2 commits intodevfrom
patch-fix-download-logs-ios
Nov 5, 2025
Merged

fix(ios): fix download logs dialog not opening on iOS#3374
ca333 merged 2 commits intodevfrom
patch-fix-download-logs-ios

Conversation

@DeckerSU
Copy link
Copy Markdown
Contributor

@DeckerSU DeckerSU commented Nov 5, 2025

Fix issue where the "Download logs" button in Settings was not opening the share dialog on iOS devices.

Changes:

  • Migrate from deprecated Share.shareXFiles() to SharePlus.instance.share() API
  • Add sharePositionOrigin parameter using scaffoldKey.currentContext for proper iPad support
  • Explicitly set mimeType and name parameters for XFile instances
  • Add break statements after each case in switch statement (required by Dart)

This ensures the share sheet dialog appears correctly on both iPhone and iPad devices when downloading log files.

…n and updating share method to use SharePlus with appropriate parameters for text and compressed files.
…gin and correct import path for app configuration.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch patch-fix-download-logs-ios

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2025

Visit the preview URL for this PR (updated for commit 96c1baa):

https://walletrc--pull-3374-merge-j0d9sfsq.web.app

(expires Wed, 12 Nov 2025 16:55:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@gcharang gcharang requested a review from ca333 November 5, 2025 17:01
@CharlVS CharlVS requested review from CharlVS and gcharang November 5, 2025 17:11
Copy link
Copy Markdown
Contributor

@gcharang gcharang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm that logs download in the web app continues to work

Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on macOS. Thanks!

@ca333 ca333 merged commit b37b0f8 into dev Nov 5, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants