Skip to content

fix(tx-history): timestamp update without navigation #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smk762 merged 3 commits into from
Nov 23, 2025
Merged

fix(tx-history): timestamp update without navigation #3352

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
090b70a
chore(tx-history): remove unused function
takenagain Nov 3, 2025
7868850
fix(tx-history): update timestamp for existing entries in tx cache/state
takenagain Nov 3, 2025
f9cbb92
Merge branch 'dev' into fix/timestamp-update-without-navigation
smk762 Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/bloc/transaction_history/transaction_history_bloc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ class TransactionHistoryBloc
blockHeight: sanitized.blockHeight,
fee: sanitized.fee ?? existing.fee,
memo: sanitized.memo ?? existing.memo,
// Update the timestamp to change date from "Now" once tx
// is confirmed on the blockchain
timestamp: sanitized.timestamp,
);
}

Expand Down Expand Up @@ -192,6 +195,9 @@ class TransactionHistoryBloc
blockHeight: sanitized.blockHeight,
fee: sanitized.fee ?? existing.fee,
memo: sanitized.memo ?? existing.memo,
// Update the timestamp to change date from "Now" once tx
// is confirmed on the blockchain
timestamp: sanitized.timestamp,
);
}

Expand Down Expand Up @@ -242,12 +248,6 @@ class TransactionHistoryBloc
emit(state.copyWith(loading: false, error: event.error));
}

DateTime _sortTime(Transaction tx) {
if (tx.timestamp.millisecondsSinceEpoch != 0) return tx.timestamp;
final firstSeen = _firstSeenAtById[tx.internalId];
return firstSeen ?? DateTime.fromMillisecondsSinceEpoch(0);
}

int _compareTransactions(Transaction left, Transaction right) {
final unconfirmedTimestamp = DateTime.fromMillisecondsSinceEpoch(0);
if (right.timestamp == unconfirmedTimestamp) {
Expand Down
Loading