Skip to content

fix: uuid copy / swap export / translations#3348

Merged
smk762 merged 8 commits intodevfrom
tweak/swap-copy-export
Nov 23, 2025
Merged

fix: uuid copy / swap export / translations#3348
smk762 merged 8 commits intodevfrom
tweak/swap-copy-export

Conversation

@smk762
Copy link
Copy Markdown
Collaborator

@smk762 smk762 commented Nov 3, 2025

Fixes #2891 additional comments.
Adding export to rows deferred until design can be determined.

  • exports as prettified json
  • exports as json file (nottxt)
  • moves export button into pair header block
  • removes duplicated swap uuid copy line
image

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tweak/swap-copy-export

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 3, 2025

Visit the preview URL for this PR (updated for commit 2a32376):

https://walletrc--pull-3348-merge-vjdzjrly.web.app

(expires Sun, 30 Nov 2025 07:55:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@gcharang
Copy link
Copy Markdown
Contributor

gcharang commented Nov 3, 2025

Adding export to rows deferred until design can be determined.

it can just be a download icon beside the swap id. it can look like:

Screenshot 2025-11-03 190832

@smk762
Copy link
Copy Markdown
Collaborator Author

smk762 commented Nov 4, 2025

Adding export to rows deferred until design can be determined.

it can just be a download icon beside the swap id. it can look like:

My main concern is how adding something so wide will work on mobile. Its a bit tricker question than the rest of the requested changes, so I did the easy, and kicked the can down the road for the difficult. As there now exists a vector to export which is a click away from the list, I figured that the additional button was a convenience rather than critical requirement, and a worthy candidate for triage to be deferred pending multi-platform design.

@gcharang
Copy link
Copy Markdown
Contributor

gcharang commented Nov 4, 2025

@smk762 got it. can only check in ios after push to testflight. but on web, LGTM

@smk762 smk762 changed the title Tweak/swap copy export fix: uuid copy / swap export / translations Nov 4, 2025
@smk762 smk762 linked an issue Nov 4, 2025 that may be closed by this pull request
@smk762 smk762 self-assigned this Nov 5, 2025
@smk762 smk762 added this to the v0.9.4 milestone Nov 5, 2025
@smk762 smk762 merged commit 0c54afc into dev Nov 23, 2025
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show swap uuid and allow export of swap data easily

3 participants