fix(transaction-history): migrate from confirmations to timestamp-based sorting#3338
fix(transaction-history): migrate from confirmations to timestamp-based sorting#3338
Conversation
This reverts the changes from 9900372 that attempted to show unconfirmed transactions first. The previous approach caused transactions to appear in a chaotic order during synchronization, creating confusion until all transactions are fully loaded.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit fd93e94): https://walletrc--pull-3338-merge-v9nhvc23.web.app (expires Tue, 11 Nov 2025 18:12:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
|
Possible duplication of #3327 |
Yes, I guess it's a duplication. My suggestion is to let the UI team decide which option fits the codebase better. From my point of view, reverting the unconfirmed transactions logic seems a bit cleaner than adding new conditions for confirmations. But that’s just my humble opinion. The final decision on which one should be closed and which should be merged is up to the UI team. |
There was a problem hiding this comment.
I am in favour of your solution of reverting to the previous timestamp-based approach, with the small tweaks suggested below. This is also consistent with Onur's comments about the move away from the confirmations field in KDF, and to rather exclusively use the timestamp field in the UI.
Could we copy over the change to update timestamps for existing entries from #3327 to lines 190 and 110. This will update the timestamp for unconfirmed transactions from "Now" to a valid timestamp as events stream in via SSE while on the page.
- Maintains prioritization of unconfirmed transactions - Adds multi-level sorting: time, block height, and internal ID - Uses _sortTime helper for better handling of zero timestamps - Ensures deterministic ordering for consistent UI display
…irmed transactions
This reverts the changes from 9900372 that attempted to show unconfirmed transactions first. The previous approach caused transactions to appear in a chaotic order during synchronization, creating confusion until all transactions are fully loaded.