Skip to content

chore(settings): add logging and avoid silent skipping#3329

Merged
smk762 merged 1 commit intosiloed-configsfrom
refactor/siloed-configs-logging
Nov 1, 2025
Merged

chore(settings): add logging and avoid silent skipping#3329
smk762 merged 1 commit intosiloed-configsfrom
refactor/siloed-configs-logging

Conversation

@takenagain
Copy link
Copy Markdown
Contributor

@takenagain takenagain commented Oct 31, 2025

Adds logging for visibility of any errors or skipped configs

@takenagain takenagain self-assigned this Oct 31, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 31, 2025

Caution

Review failed

An error occurred during the review process. Please try again later.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/siloed-configs-logging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@takenagain takenagain marked this pull request as ready for review October 31, 2025 22:25
Copilot AI review requested due to automatic review settings October 31, 2025 22:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling and logging for settings loading in the Market Maker Bot configuration. The changes enhance debugging capabilities by adding structured logging when invalid configurations are encountered and updating error handling to capture full stack traces.

  • Added logging for invalid trade coin pair configurations with detailed error information
  • Improved error handling in settings repository to log warnings with stack traces
  • Refactored code formatting for better readability

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
lib/model/settings/market_maker_bot_settings.dart Added Logger import and instance, enhanced error handling with logging for invalid trade coin pair configs, improved type checking and error messages
lib/bloc/settings/settings_repository.dart Added Logger import and instance, replaced silent error handling with logged warnings including stack traces

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@takenagain takenagain force-pushed the refactor/siloed-configs-logging branch from 0ba9719 to 4d4a258 Compare October 31, 2025 22:29
@takenagain takenagain requested a review from smk762 October 31, 2025 22:31
Copy link
Copy Markdown
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extras

@smk762 smk762 merged commit b148ab8 into siloed-configs Nov 1, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants