Skip to content

fix(tx-history): only consider empty timestamp and confs as unconfirmed #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
takenagain wants to merge 2 commits into from
Closed

fix(tx-history): only consider empty timestamp and confs as unconfirmed #3327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
121cb89
fix(tx-history): only consider empty timestamp and confs as unconfirmed
takenagain Oct 31, 2025
9c818b2
Merge branch 'dev' into fix/tx-history-sorting
takenagain Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/bloc/transaction_history/transaction_history_bloc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ class TransactionHistoryBloc
blockHeight: sanitized.blockHeight,
fee: sanitized.fee ?? existing.fee,
memo: sanitized.memo ?? existing.memo,
// Update the timestamp to change date from "Now" once tx
// is confirmed on the blockchain
timestamp: sanitized.timestamp,
);
}

Expand Down Expand Up @@ -250,8 +253,12 @@ class TransactionHistoryBloc

int _compareTransactions(Transaction left, Transaction right) {
// Unconfirmed (pending) transactions should appear first.
final leftIsUnconfirmed = left.confirmations == 0;
final rightIsUnconfirmed = right.confirmations == 0;
// Because tx stream events don't include confirmations, only consider
// 0 confirmations AND 0 timestamp as unconfirmed (1970)
final leftIsUnconfirmed =
left.confirmations == 0 && left.timestamp.millisecondsSinceEpoch == 0;
final rightIsUnconfirmed =
right.confirmations == 0 && right.timestamp.millisecondsSinceEpoch == 0;

if (leftIsUnconfirmed != rightIsUnconfirmed) {
return leftIsUnconfirmed ? -1 : 1;
Expand Down
Loading