Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe changes introduce a new RpcExtras utility class to encapsulate coin-specific RPC parameters for withdrawal operations. The class provides a withdrawForCoin method that returns KMD-specific rewards configuration, while other coins receive empty parameter maps. The WithdrawRequest is updated to integrate these extras into its JSON serialization. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit 8c34ba1): https://walletrc--pull-3289-merge-aw47txlv.web.app (expires Wed, 05 Nov 2025 06:03:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
update params ref. breaking changes
Summary by CodeRabbit