Skip to content

revert toggle on zhtlc activation config cancel#3283

Merged
ca333 merged 2 commits intodevfrom
fix-canceled-zhtlc-toggle
Oct 29, 2025
Merged

revert toggle on zhtlc activation config cancel#3283
ca333 merged 2 commits intodevfrom
fix-canceled-zhtlc-toggle

Conversation

@smk762
Copy link
Copy Markdown
Collaborator

@smk762 smk762 commented Oct 28, 2025

closes #3282

To test:

  • login with a fresh wallet (clear cache or incognito)
  • go to add assets page
  • toggle ARRR on to initiate activation. The sync params menu should appear.
  • Press cancel to exit the menu, and abort activation.
  • confirm toggle slides back into the disabled position.

@smk762 smk762 self-assigned this Oct 28, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-canceled-zhtlc-toggle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@smk762 smk762 added the P2 Time permissive label Oct 28, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2025

Visit the preview URL for this PR (updated for commit 7c79a2f):

https://walletrc--pull-3283-merge-840uda6i.web.app

(expires Wed, 05 Nov 2025 06:22:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it!

@ca333 ca333 merged commit 1ade9f0 into dev Oct 29, 2025
7 of 13 checks passed
@ca333 ca333 mentioned this pull request Oct 29, 2025
@smk762 smk762 mentioned this pull request Nov 23, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Time permissive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants