Skip to content

Align coin activation state in fiat ramp page with portfolio view#3272

Merged
ca333 merged 6 commits intodevfrom
align-activation=state
Oct 29, 2025
Merged

Align coin activation state in fiat ramp page with portfolio view#3272
ca333 merged 6 commits intodevfrom
align-activation=state

Conversation

@smk762
Copy link
Copy Markdown
Collaborator

@smk762 smk762 commented Oct 28, 2025

Closes #3271

  • Updates activation of selected coin in fiat ramp form to use the common coinsRepo, to ensure it appears subsequently in portfolio view, and is correctly marked as active in the activation menu.
  • Restores BTC-segwit to the enabledByDefaultCoins list, as it is the default selection in the fiat ramp form

To test:

  • Create and log in with a fresh wallet
  • Confirm KMD and BTC-segwit enabled by default
  • Go to fiat ramp page
  • Select any coin not already activated, and wait for its addresses to load
  • Return to the portfolio page
  • Confirm coin selected in fiat form appears in the portfolio coins list
  • Enter the Add Assets menu
  • Confirm coin selected in fiat form toggle is in the correct position to indicate it is active

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch align-activation=state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@smk762 smk762 linked an issue Oct 28, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2025

Visit the preview URL for this PR (updated for commit 8c8bb2b):

https://walletrc--pull-3272-merge-v2pan1ah.web.app

(expires Wed, 05 Nov 2025 06:24:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

Copy link
Copy Markdown
Contributor

@takenagain takenagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed activation state alignment in Web, including parent assets when a child/token is selected. Additionally, verified that the same behaviour occurs on the Swap (Sell and Buy) and Bridge pages via activateCoinIfNeeded.

@smk762 smk762 self-assigned this Oct 28, 2025
@smk762 smk762 added the P1 Major issue needs to be fixed label Oct 28, 2025
@ca333 ca333 merged commit a54f065 into dev Oct 29, 2025
7 of 13 checks passed
@ca333 ca333 mentioned this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 Major issue needs to be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fiat tab activated coins not seen in portfolio view

3 participants