Skip to content

show only compatible activation filter options#3249

Merged
ca333 merged 2 commits intodevfrom
reduced-trezor-filter
Oct 27, 2025
Merged

show only compatible activation filter options#3249
ca333 merged 2 commits intodevfrom
reduced-trezor-filter

Conversation

@smk762
Copy link
Copy Markdown
Collaborator

@smk762 smk762 commented Oct 26, 2025

closes #2876

To test:

  • login with trezor
  • go to coin activation menu
  • open filter
  • see only trezor compatible options

Summary by CodeRabbit

  • Bug Fixes
    • Improved coin filter visibility in Trezor wallet mode to accurately reflect coins present in the current view, accounting for applied search and filter settings.
    • Enhanced code clarity with additional explanatory comments.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Modified the coin filter dropdown for Trezor mode to source filter options from the current CoinsManagerBloc state instead of the CoinsBloc state. This narrows visible filter options to only coins present in the actively displayed list, reflecting search and test-coin filters applied to the UI.

Changes

Cohort / File(s) Summary
Trezor Filter Source Update
lib/views/wallet/coins_manager/coins_manager_filters_dropdown.dart
Changed _filterTypes for WalletType.trezor to reference bloc.state.coins instead of coinsBloc.state.coins.values; added explanatory comment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Focus on verifying the state source change correctly reflects the intended behavior: filter options now align with the active UI list rather than the complete coin registry
  • Confirm the comment accurately describes the logic shift
  • Validate that no edge cases arise from the state dependency change (e.g., stale data or race conditions with bloc state updates)

Poem

🐰 A filter finds its perfect home,
No more coins beyond the dome,
What you search is what you see,
Trezor's list, now clear and free! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "show only compatible activation filter options" accurately captures the main outcome of the code changes. The modification switches the coin existence check source for Trezor mode to display only compatible filter options rather than all available options. The title is concise, specific, and clearly conveys the primary change without being misleading or overly vague.
Linked Issues Check ✅ Passed The code changes directly address the requirements from issue #2876. The modification to _filterTypes for WalletType.trezor switches the source from coinsBloc.state.coins.values to bloc.state.coins, restricting the displayed filter options to only coins currently visible in the list. This implementation fulfills both stated objectives: reducing the filter options in Trezor mode and ensuring only Trezor-compatible options are shown.
Out of Scope Changes Check ✅ Passed All changes are directly scoped to the stated objective of reducing filter options in Trezor mode. Only one file is modified with a focused change to the coin filter logic specific to Trezor wallet type. An explanatory comment was added to clarify the logic. No alterations to exported or public entities were made, and no unrelated changes are present outside the scope of issue #2876.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 26, 2025

Visit the preview URL for this PR (updated for commit fb3f903):

https://walletrc--pull-3249-merge-x5k92n5y.web.app

(expires Mon, 03 Nov 2025 23:36:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@ca333 ca333 changed the base branch from main to dev October 27, 2025 23:31
@ca333 ca333 merged commit 18c4a4d into dev Oct 27, 2025
6 of 12 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce coin activation list filter in Trezor mode

2 participants