Skip to content

chore(sdk): roll to fix/asset-chain-tagging#3199

Merged
CharlVS merged 6 commits intodevfrom
fix/asset-chain-tagging
Oct 20, 2025
Merged

chore(sdk): roll to fix/asset-chain-tagging#3199
CharlVS merged 6 commits intodevfrom
fix/asset-chain-tagging

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Oct 17, 2025

Roll SDK submodule to latest fix branch

  • Switch to (published)
  • Ensure UTXO coins are tagged Native; only Smart Chain when explicitly configured

Refs: #3200


Note

Update sdk submodule to new commit and remove lib/analytics/analytics_factory.dart.

  • Dependencies:
    • Bump sdk submodule to ec40963.
  • Analytics:
    • Remove lib/analytics/analytics_factory.dart (all analytics event classes and factory methods).

Written by Cursor Bugbot for commit 317e8a3. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/asset-chain-tagging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CharlVS CharlVS changed the title chore(sdk): roll to bugfix/activation-asset-grouping for asset tagging fix chore(sdk): roll to fix/asset-chain-tagging Oct 18, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 18, 2025

Visit the preview URL for this PR (updated for commit 317e8a3):

https://walletrc--pull-3199-merge-y32g5qsk.web.app

(expires Sun, 26 Oct 2025 17:36:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@CharlVS CharlVS marked this pull request as draft October 18, 2025 16:16
@CharlVS CharlVS requested a review from gcharang October 18, 2025 16:18
@CharlVS CharlVS self-assigned this Oct 18, 2025
@CharlVS CharlVS marked this pull request as ready for review October 18, 2025 16:19
- Sanitize ticker parsing for exact/partial matches\n- Restore partial ticker matching to preserve behavior\n- Prefer UTXO on exact "UTXO" to avoid mislabeling\n- Catch StateError specifically and deduplicate enum name extraction\n- Confirm UTXO formatted label is "Native"
cursor[bot]

This comment was marked as outdated.

@CharlVS CharlVS merged commit 92d5140 into dev Oct 20, 2025
8 of 14 checks passed
@CharlVS CharlVS deleted the fix/asset-chain-tagging branch October 20, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Ready for QA Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants