chore(analytics): update completed events and remove scroll attempt tracking

[CharlVS]

Summary

• remove the scroll_attempt_outside_content analytics wiring and note that it will return later
• refresh required_analytics_events.csv to flag the implemented events as completed
• document the temporary removal in the analytics implementation plan

Testing

• flutter analyze (fails: current Flutter SDK 3.32.5 < required 3.35.3)

---

https://chatgpt.com/codex/tasks/task_e_68f125e42ba88326a97aea29dd727dc3

---

Note

Removes the scroll_attempt_outside_content analytics event and all references, updates the required events CSV to mark implemented items as complete, and documents the temporary removal.

• Analytics:
  • Remove scroll_attempt_outside_content event: delete event classes/wrappers in lib/analytics/analytics_factory.dart and lib/analytics/events/misc_events.dart, drop logging from wallet_main.dart, and remove category mapping in bloc/analytics/matomo_analytics_api.dart.
• Data/Docs:
  • Update lib/analytics/required_analytics_events.csv: mark many events as TRUE and remove scroll_attempt_outside_content row.
  • Add note in docs/ANALYTICS_EVENT_IMPLEMENTATION_PLAN.md about temporary removal of scroll_attempt_outside_content.

^{Written by Cursor Bugbot for commit d786295. This will update automatically on new commits. Configure here.}

Summary by CodeRabbit

• Chores
  • Removed the scroll_attempt_outside_content analytics event. This event has been temporarily disabled and will be re-implemented when updated instrumentation is ready. No impact to user-facing features or app functionality.

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

The scroll_attempt_outside_content analytics event is being systematically removed across the codebase. This includes removing the event definition, associated data classes, event category mappings, and its logging usage in wallet functionality. A temporary note documents this pending re-implementation with updated UX instrumentation.

Changes

Cohort / File(s)	Summary
Documentation docs/ANALYTICS_EVENT_IMPLEMENTATION_PLAN.md	Removed scroll_attempt_outside_content table entry; added explanatory note on temporary removal and planned re-implementation.
Event Definitions lib/analytics/analytics_factory.dart, lib/analytics/events/misc_events.dart	Removed ScrollAttemptOutsideContentEvent class and ScrollAttemptOutsideContentEventData class definitions, including constructor, name override, field declarations (screenContext, scrollDelta), and parameter mappings.
Event Category Mapping lib/bloc/analytics/matomo_analytics_api.dart	Removed 'scroll_attempt_outside_content' key from the event category mapping under UX & UI section in _eventCategoryMap.
Event Usage lib/views/wallet/wallet_page/wallet_main/wallet_main.dart	Removed import of misc_events.dart and eliminated ScrollAttemptOutsideContentEventData logging call in WalletMain._onPointerSignal when newOffset equals current scroll offset.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

The changes follow a consistent, homogeneous pattern of removing the same event across multiple layers (documentation, definitions, mappings, and usage). While spread across 5 files, the removal logic is repetitive and straightforward, requiring verification that the event is completely excised without breaking dependencies.

Suggested reviewers

• takenagain

Poem

🐰 A scroll event hops away today,
Temporarily dormant, it will stay,
When UX instrumentation's bright and new,
Our little event will hop back through! ✨
For now it rests in notes so tidy,
Awaiting its return on redesign Friday! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title "chore(analytics): update completed events and remove scroll attempt tracking" is directly related to the primary change in the changeset. The second part of the title, "remove scroll attempt tracking," accurately and specifically describes the main focus of the PR—the systematic removal of the scroll_attempt_outside_content analytics event from multiple locations across the codebase (factory, event definitions, API mappings, and usage). The first part, "update completed events," refers to secondary updates mentioned in the PR objectives (marking other events as completed in the tracking matrix). The title is concise, clear enough for a teammate to understand the primary change when scanning commit history, and avoids vague terminology.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/remove-scroll_attempt_outside_content-event

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

https://github.com/KomodoPlatform/komodo-wallet/blob/ee3afc9d96aba0b6687cb23e2decb2ae3d16d314/lib/analytics/analytics_factory.dart#L408-L414
Remove scroll event class without deleting factory reference

The commit deletes the ScrollAttemptOutsideContentEvent class and its event data, but AnalyticsFactory.scrollAttemptOutsideContent() still returns that type. After this change the type no longer exists anywhere in the repo, so this method now references an undefined symbol and the app fails to compile. Either remove the factory helper or leave the event class in place until all call sites are removed.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

• @codex fix this CI failure
• @codex address that feedback

[github-actions]

Visit the preview URL for this PR (updated for commit d786295):

https://walletrc--pull-3194-merge-di2gs6gj.web.app

_{(expires Fri, 24 Oct 2025 16:37:11 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

[CharlVS]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[CharlVS]

@cursor review

[Copilot]

Pull Request Overview

This PR temporarily removes the scroll_attempt_outside_content analytics event and updates the CSV tracking file to mark most previously unimplemented events as completed.

• Removes all code related to the scroll_attempt_outside_content event (event definitions, category mappings, and emission)
• Updates required_analytics_events.csv to mark 28 events as completed (changed from FALSE to TRUE)
• Documents the temporary removal of the scroll event in the implementation plan

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
lib/views/wallet/wallet_page/wallet_main/wallet_main.dart	Removes scroll event emission logic and related import
lib/bloc/analytics/matomo_analytics_api.dart	Removes event-to-category mapping entry
lib/analytics/required_analytics_events.csv	Removes scroll event row and marks 28 events as completed
lib/analytics/events/misc_events.dart	Removes scroll event data class and wrapper event
lib/analytics/analytics_factory.dart	Removes duplicate scroll event class definition
docs/ANALYTICS_EVENT_IMPLEMENTATION_PLAN.md	Adds note explaining temporary removal of scroll event

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}