fix(icons,splash): mirror native app icons and startup screens from legacy by CharlVS · Pull Request #3189 · GLEECBTC/gleec-wallet

CharlVS · 2025-10-16T14:55:26Z

This PR manually mirrors native app icons and startup screens from the legacy repos. Current icons are broken/ugly.

Changes

iOS: replaced AppIcon.appiconset; LaunchScreen.storyboard now uses legacy AppLogo imageset
Android: mirrored adaptive app icons and replaced launch_background.xml
Desktop
- macOS: AppIcon.appiconset PNGs now match legacy (all sizes)
- Windows: .ico already matched legacy
- Linux: KomodoWallet.png replaced with legacy dex-logo.png

Verification

flutter pub get --enforce-lockfile --offline
flutter analyze (no new issues from these changes)
Checksums verified for desktop icons (macOS sizes, Windows .ico, Linux PNG)

Acceptance criteria

All platforms display the same icons and startup screens as legacy.

Screenshots (Not all platforms included)

Windows

Before:

After:

macOS

Before:

After:
...

Note

Updates app icons and splash assets across Android, iOS, Web, and Linux, switching logo references to WEBP/PNG and adjusting configs; bumps SDK submodule.

Branding/Assets:
- Switch logo URL and web references to logo_icon.webp (web prefetch/loading, komodoLogoUrl).
Android:
- Splash: launch_background.xml now uses @color/background_color and centers @mipmap/launcher_icon_foreground.
- Adaptive icon: foreground set to @mipmap/launcher_icon_foreground.
- Add values/colors.xml with background_color and icon_foreground_color.
iOS:
- Replace AppIcon.appiconset/Contents.json with full device/marketing sizes.
- LaunchScreen storyboard metadata updated.
Linux:
- Use PNG icon: update .desktop and my_application.cc to KomodoWallet.png; install PNG in CMakeLists.txt; remove SVG.
SDK:
- Update sdk submodule commit.

^{Written by Cursor Bugbot for commit b225f06. This will update automatically on new commits. Configure here.}

- Replace Linux icon: remove SVG, add PNG, update .desktop - Update macOS AppIcon assets (16-1024 px) - Update Windows app icon (.ico) - Adjust Linux runner code for app icon

…n, Android launch_background)

coderabbitai · 2025-10-16T14:55:37Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/native-platform-app-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-10-16T15:01:15Z

Visit the preview URL for this PR (updated for commit b225f06):

https://walletrc--pull-3189-merge-fy9hhuug.web.app

_{(expires Mon, 27 Oct 2025 18:50:57 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

smk762 · 2025-10-17T04:27:29Z

Should we update the web splash loading icon also for consistency?

vokoscreenNG-2025-10-17_12-26-22.mp4

smk762 · 2025-10-17T05:01:09Z

Linux icon is not applied. This was the case prior to this PR also.

smk762 · 2025-10-17T05:14:23Z

Windows icon update confirmed ✔️
Android icon update confirmed ✔️
Unable to confirm MacOS/iOS until binaries are available.

…NG logo with WebP variants for app and web\n- Update iOS AppLogo images and Contents.json\n- Remove deprecated app_logo-1x/2x assets\n- Update web/index.html references to new logo\n- Format changed Dart file in ramp fiat provider\n\nRefs: fix/native-platform-app-icons

…into fix/native-platform-app-icons

Update prefetch and img src to /assets/assets/app_icon/logo_icon.webp to match Flutter web bundling and fix 404s on Firebase Hosting rewrites.

smk762 · 2025-10-20T05:33:52Z

Failing path: https://walletrc--pull-3189-merge-fy9hhuug.web.app/assets/assets/app_icon/logo_icon.webp

…uncher XML for adaptive icons

…into fix/native-platform-app-icons # Conflicts: # sdk

Copilot

Pull Request Overview

This PR updates native app icons and splash screens across all platforms (iOS, Android, Web, Linux) to mirror the legacy application's assets, replacing broken or inconsistent icons. Key changes include switching from PNG to WEBP for web assets and updating platform-specific icon configurations.

Replaces iOS AppIcon.appiconset with full icon set matching legacy
Updates Android adaptive icons and splash screen to use new foreground assets
Switches Linux desktop icon from SVG to PNG format
Migrates web assets to WEBP format and updates Ramp logo URL

Reviewed Changes

Copilot reviewed 10 out of 53 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
web/index.html	Updates prefetch and splash image paths to use WEBP format
sdk	Updates submodule commit reference
linux/my_application.cc	Changes window icon from SVG to PNG
linux/KomodoWallet.desktop	Updates desktop icon path to PNG
lib/bloc/fiat/ramp/ramp_fiat_provider.dart	Changes Komodo logo URL to WEBP and reformats code
ios/Runner/Base.lproj/LaunchScreen.storyboard	Updates toolsVersion metadata
ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json	Adds complete icon set for all iOS device sizes
android/app/src/main/res/values/colors.xml	Adds color resources for splash screen
android/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml	Updates adaptive icon to use new foreground mipmap
android/app/src/main/res/drawable/launch_background.xml	Updates splash screen to use new color and foreground assets

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

web/index.html

ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json

android/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml

…into fix/native-platform-app-icons # Conflicts: # macos/Podfile.lock # sdk

…nces

CharlVS

Review Comments Verification Complete ✅

Based on thorough code verification, all review comments have been addressed:

1. Web Asset Path (Copilot AI)

✅ FIXED - The duplicate 'assets' directory issue is fixed. Paths correctly use /icons/logo_icon.webp without duplication.

2. iOS Icon Idiom (Copilot AI)

✅ NOT AN ISSUE - The ios-marketing idiom for 1024x1024 icons is the correct iOS standard, not an error.

3. Android Foreground Resource (Copilot AI)

✅ NOT AN ISSUE - All required launcher_icon_foreground.png files exist in the appropriate mipmap directories (mdpi, hdpi, xhdpi, xxhdpi, xxxhdpi).

4. WebP File Missing (cursor[bot])

✅ NOT AN ISSUE - Both logo_icon.webp files exist at:

web/icons/logo_icon.webp
assets/app_icon/logo_icon.webp

All identified issues were either already fixed or were false positives. The implementation is correct and complete.

smk762

LGTM

CharlVS added 5 commits October 16, 2025 16:12

fix(icons): update native platform app icons and desktop entry

dda524d

- Replace Linux icon: remove SVG, add PNG, update .desktop - Update macOS AppIcon assets (16-1024 px) - Update Windows app icon (.ico) - Adjust Linux runner code for app icon

fix(icons): align iOS/Android app icons with legacy build

e052a67

fix(splash): mirror startup screen from legacy build (iOS LaunchScree…

cdc47b0

…n, Android launch_background)

fix(ios): align AppLogo.imageset Contents.json with legacy images

4277c8b

fix(desktop): mirror macOS AppIcon and Linux icon from legacy desktop

010bbca

CharlVS requested review from DeckerSU and smk762 October 16, 2025 15:08

CharlVS self-assigned this Oct 16, 2025

CharlVS changed the title ~~fix(icons,splash,desktop): mirror native app icons and startup screens from legacy~~ fix(icons,splash): mirror native app icons and startup screens from legacy Oct 16, 2025

chore(sdk): bump submodule to GLEECBTC/komodo-defi-sdk-flutter@717fe64

f070275

CharlVS force-pushed the fix/native-platform-app-icons branch from a54f93d to a51d238 Compare October 17, 2025 18:25

Merge branch 'dev' of https://github.com/KomodoPlatform/komodo-wallet …

fe6f664

…into fix/native-platform-app-icons

This comment was marked as outdated.

Sign in to view

fix(web): correct logo asset path in index.html for production hosting

229c9ce

Update prefetch and img src to /assets/assets/app_icon/logo_icon.webp to match Flutter web bundling and fix 404s on Firebase Hosting rewrites.

CharlVS added 2 commits October 20, 2025 15:15

fix(web,android): update app icon and favicon refs; ensure correct la…

2b09583

…uncher XML for adaptive icons

Merge branch 'dev' of https://github.com/KomodoPlatform/komodo-wallet …

f0915ae

…into fix/native-platform-app-icons # Conflicts: # sdk

CharlVS requested a review from Copilot October 20, 2025 13:27

Copilot AI reviewed Oct 20, 2025

View reviewed changes

web/index.html Outdated Show resolved Hide resolved

ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json Show resolved Hide resolved

android/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

CharlVS added 4 commits October 20, 2025 15:41

Merge branch 'dev' of https://github.com/KomodoPlatform/komodo-wallet …

86ef0ae

…into fix/native-platform-app-icons # Conflicts: # macos/Podfile.lock # sdk

chore(sdk): update submodule to latest dev

038abd4

chore(macos/ios): role native dependencies lock files

034cc7a

fix(icons): correct Linux app icon config and update web index refere…

45c7bb3

…nces

This comment was marked as outdated.

Sign in to view

CharlVS commented Oct 20, 2025

View reviewed changes

CharlVS requested review from smk762 and removed request for smk762 October 20, 2025 14:57

smk762 approved these changes Oct 20, 2025

View reviewed changes

Merge branch 'dev' into fix/native-platform-app-icons

b225f06

CharlVS merged commit 28c9734 into dev Oct 20, 2025
7 of 13 checks passed

Conversation

CharlVS commented Oct 16, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots (Not all platforms included)

Windows

macOS

Uh oh!

coderabbitai bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smk762 commented Oct 17, 2025

Uh oh!

smk762 commented Oct 17, 2025

Uh oh!

smk762 commented Oct 17, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

smk762 commented Oct 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

CharlVS left a comment

Choose a reason for hiding this comment

Review Comments Verification Complete ✅

1. Web Asset Path (Copilot AI)

2. iOS Icon Idiom (Copilot AI)

3. Android Foreground Resource (Copilot AI)

4. WebP File Missing (cursor[bot])

Uh oh!

smk762 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CharlVS commented Oct 16, 2025 •

edited by cursor bot

Loading

coderabbitai bot commented Oct 16, 2025 •

edited

Loading

github-actions bot commented Oct 16, 2025 •

edited

Loading