Skip to content

ci: fix missing secrets and remove duplicate steps in CI workflows#3167

Merged
CharlVS merged 4 commits intodevfrom
fix/desktop-ci-missing-secrets
Oct 4, 2025
Merged

ci: fix missing secrets and remove duplicate steps in CI workflows#3167
CharlVS merged 4 commits intodevfrom
fix/desktop-ci-missing-secrets

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Oct 3, 2025

Summary

This PR fixes CI workflows to properly pass all required secrets (including Matomo analytics), removes duplicate build steps, and adds missing artifact uploads to Docker workflows.

Changes

Duplicate Build Steps Removed

  • Mobile builds: Removed duplicate generate-assets action call
  • Desktop builds: Removed duplicate generate-assets action call
  • Renamed action and steps to clarify they perform both dry-run and actual build

Missing Secrets Added

  • Desktop & Mobile builds: Added MATOMO_URL and MATOMO_SITE_ID
  • Docker builds (Android & Linux): Added all Trello, Feedback, and Matomo secrets
  • Firebase hosting workflows: Added Matomo secrets to merge workflow
  • SDK integration preview: Added Matomo secrets

Artifact Uploads Added

  • Docker Android build: Now uploads APK artifact (komodo-wallet-android-docker.apk)
  • Docker Linux build: Now uploads Linux bundle artifact (komodo-wallet-linux-docker.zip)
  • Both with 5-day retention

Action Improvements

  • Renamed generate-assets action to better reflect it handles complete build process
  • Updated description to clarify dry-run + actual build workflow

Motivation

The workflows were:

  1. Missing Matomo secrets - causing analytics to be disabled in CI builds with warning: "CI environment detected without Matomo config"
  2. Calling build twice - both mobile-builds.yml and desktop-builds.yml were calling the generate-assets action twice with identical parameters
  3. Incomplete Docker configurations - docker-linux-build.yml was missing all feedback/analytics secrets that docker-android-build.yml had
  4. Missing artifact uploads - Docker workflows were building but not uploading artifacts to GitHub Actions, only showing logs with no downloadable builds

Performance Impact

Desktop Build Times (vs. dev branch)

Linux builds:

  • Before: 9m 24s average
  • After: 4m 20s average
  • Improvement: 5m 4s (53.9% faster)

Windows builds:

  • Before: 14m 36s average
  • After: 13m 57s average
  • Improvement: 38s (4.4% faster)

Overall average:

  • Before: 12m 0s
  • After: 9m 8s
  • Improvement: 2m 51s (23.8% faster)

The significant Linux build improvement is primarily due to removing duplicate build step execution.

Testing

  • Verified all secrets exist in repository using gh secret list
  • Confirmed build.sh script reads environment variables correctly
  • All workflows now properly pass secrets to build processes
  • Artifact paths match Flutter build output directories
  • Build time improvements verified across multiple workflow runs

…ch patterns

- Add fix/* and add/* branches to workflow triggers
- Replace direct build command with generate-assets action to properly pass secrets
- Ensures TRELLO and FEEDBACK secrets are available during build step
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/desktop-ci-missing-secrets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 3, 2025

Visit the preview URL for this PR (updated for commit b888afc):

https://walletrc--pull-3167-merge-7clmb1c7.web.app

(expires Fri, 10 Oct 2025 10:32:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

- Remove duplicate generate-assets action calls in mobile and desktop builds
- Rename action and steps to clarify they perform both dry-run and actual build
- Update action description to reflect complete build process
- Add MATOMO_URL and MATOMO_SITE_ID to desktop and mobile builds
- Add all feedback and analytics secrets to Docker builds (Android and Linux)
- Add Matomo secrets to Firebase hosting and SDK integration workflows
- Ensures analytics are properly configured across all build pipelines
@CharlVS CharlVS changed the title fix(ci): update desktop-builds workflow with missing secrets and branch patterns ci: fix missing secrets and remove duplicate steps in CI workflows Oct 3, 2025
@CharlVS CharlVS requested review from DeckerSU and smk762 October 3, 2025 10:19
@CharlVS CharlVS self-assigned this Oct 3, 2025
@CharlVS CharlVS added CI bug Something isn't working labels Oct 3, 2025
- Add upload-artifact step to docker-android-build.yml for APK
- Add upload-artifact step to docker-linux-build.yml for Linux bundle
- Set 5-day retention for both artifacts
- Fixes missing build artifacts in GitHub Actions
@CharlVS CharlVS requested a review from gcharang October 3, 2025 10:47
Copy link
Copy Markdown
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the binaries produced by this PR, and it looks like MATOMO_URL and everything else are built and compiled in. So, LGTM.

@CharlVS CharlVS merged commit a58c900 into dev Oct 4, 2025
8 of 14 checks passed
@CharlVS CharlVS deleted the fix/desktop-ci-missing-secrets branch October 4, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants