ci: fix missing secrets and remove duplicate steps in CI workflows#3167
ci: fix missing secrets and remove duplicate steps in CI workflows#3167
Conversation
…ch patterns - Add fix/* and add/* branches to workflow triggers - Replace direct build command with generate-assets action to properly pass secrets - Ensures TRELLO and FEEDBACK secrets are available during build step
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit b888afc): https://walletrc--pull-3167-merge-7clmb1c7.web.app (expires Fri, 10 Oct 2025 10:32:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
- Remove duplicate generate-assets action calls in mobile and desktop builds - Rename action and steps to clarify they perform both dry-run and actual build - Update action description to reflect complete build process
- Add MATOMO_URL and MATOMO_SITE_ID to desktop and mobile builds - Add all feedback and analytics secrets to Docker builds (Android and Linux) - Add Matomo secrets to Firebase hosting and SDK integration workflows - Ensures analytics are properly configured across all build pipelines
- Add upload-artifact step to docker-android-build.yml for APK - Add upload-artifact step to docker-linux-build.yml for Linux bundle - Set 5-day retention for both artifacts - Fixes missing build artifacts in GitHub Actions
DeckerSU
left a comment
There was a problem hiding this comment.
I checked the binaries produced by this PR, and it looks like MATOMO_URL and everything else are built and compiled in. So, LGTM.
Summary
This PR fixes CI workflows to properly pass all required secrets (including Matomo analytics), removes duplicate build steps, and adds missing artifact uploads to Docker workflows.
Changes
Duplicate Build Steps Removed
generate-assetsaction callgenerate-assetsaction callMissing Secrets Added
MATOMO_URLandMATOMO_SITE_IDArtifact Uploads Added
komodo-wallet-android-docker.apk)komodo-wallet-linux-docker.zip)Action Improvements
generate-assetsaction to better reflect it handles complete build processMotivation
The workflows were:
Performance Impact
Desktop Build Times (vs.
devbranch)Linux builds:
Windows builds:
Overall average:
The significant Linux build improvement is primarily due to removing duplicate build step execution.
Testing
gh secret list