-
Notifications
You must be signed in to change notification settings - Fork 250
chore(release): v0.9.3 #3164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): v0.9.3 #3164
Changes from all commits
85e1647
e73ce15
30256fe
3dd68a7
844683e
0d84aa6
22a0833
9cdf5c1
649001d
26fe733
91823e7
a45e7b4
2658d25
2ee41c3
0351be1
a6579da
96423f7
e6dc542
7995423
fcd85e3
7c1ea69
b65f54b
5e83be8
bbef719
c15fdbe
8ede0e2
b8858c6
cf0a393
f66f16f
61d53c1
4da682b
93e94db
043e8d3
f2d775d
5f689c7
49684f1
fed5f3a
970dd30
5848741
1669ea2
b49bc45
fc1fe61
bfb650d
d33ba24
0d03442
a6afdf0
c91431e
a58c900
7a532c4
1357991
f1a92f9
137dd4f
2144a67
f042412
8cd8b52
8ee26a4
a1ce943
c838de8
92d5140
2ec7a2e
6765fa9
28c9734
65b6a8b
9a9564d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Add directories or file patterns to ignore during indexing (e.g. foo/ or *.csv) | ||
| AGENTS/ | ||
| AGENTS.md |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| # Initialize and pin submodules to the recorded commits | ||
| git submodule sync --recursive | ||
| git submodule update --init --recursive --checkout | ||
|
|
||
| # Recommended git settings for submodules | ||
| git config fetch.recurseSubmodules on-demand | ||
| git config submodule.sdk.ignore dirty | ||
|
|
||
| echo "postCreate: completed submodule initialization and permissions setup" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,11 +26,11 @@ ENV ANDROID_SDK_ROOT=$ANDROID_HOME \ | |
| ENV ANDROID_SDK_TOOLS_VERSION=11076708 | ||
|
|
||
| # https://developer.android.com/studio/releases/build-tools | ||
| ENV ANDROID_PLATFORM_VERSION=35 | ||
| ENV ANDROID_PLATFORM_VERSION=36 | ||
| ENV ANDROID_BUILD_TOOLS_VERSION=35.0.1 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Upgrade build tools alongside the API 36 bump We now install -ENV ANDROID_BUILD_TOOLS_VERSION=35.0.1
+ENV ANDROID_BUILD_TOOLS_VERSION=36.0.0🤖 Prompt for AI Agents |
||
|
|
||
| # https://developer.android.com/ndk/downloads | ||
| ENV ANDROID_NDK_VERSION=27.2.12479018 | ||
| ENV ANDROID_NDK_VERSION=27.3.13750724 | ||
|
|
||
| RUN set -o xtrace \ | ||
| && sudo chown -R $USER:$USER /opt \ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,19 @@ fi | |
|
|
||
| echo "Building with target: $BUILD_TARGET, mode: $BUILD_MODE" | ||
|
|
||
| # Ensure submodule is initialized and pinned to the recorded commit | ||
| if command -v git >/dev/null 2>&1; then | ||
| echo "Ensuring SDK submodule is initialized and pinned..." | ||
| # Keep local submodule config in sync with .gitmodules (e.g., update=checkout) | ||
| git submodule sync --recursive || true | ||
| # Clean submodules to discard local changes and untracked files | ||
| git submodule foreach --recursive "git reset --hard && git clean -fdx" || true | ||
| # Initialize and checkout recorded commits (pinned) | ||
| git submodule update --init --recursive --checkout || true | ||
| # Enable on-demand fetch for submodules (helps when switching branches) | ||
| git config fetch.recurseSubmodules on-demand || true | ||
| fi | ||
|
|
||
| if [ "$(uname)" = "Darwin" ]; then | ||
| PLATFORM_FLAG="--platform linux/amd64" | ||
| else | ||
|
|
@@ -42,34 +55,72 @@ mkdir -p ./build | |
|
|
||
| COMMIT_HASH=$(git rev-parse --short HEAD | cut -c1-7) | ||
|
|
||
| # Only pass GITHUB_API_PUBLIC_READONLY_TOKEN as environment variable | ||
| ENV_ARGS="" | ||
| ENV_VARS="GITHUB_API_PUBLIC_READONLY_TOKEN TRELLO_API_KEY \ | ||
| TRELLO_TOKEN TRELLO_BOARD_ID TRELLO_LIST_ID \ | ||
| FEEDBACK_API_KEY FEEDBACK_PRODUCTION_URL FEEDBACK_TEST_URL \ | ||
| COMMIT_HASH" | ||
| if [ -n "$GITHUB_API_PUBLIC_READONLY_TOKEN" ]; then | ||
| ENV_ARGS="-e GITHUB_API_PUBLIC_READONLY_TOKEN=$GITHUB_API_PUBLIC_READONLY_TOKEN" | ||
| fi | ||
|
|
||
| for VAR in $ENV_VARS; do | ||
| case "$VAR" in | ||
| GITHUB_API_PUBLIC_READONLY_TOKEN) VALUE=$GITHUB_API_PUBLIC_READONLY_TOKEN ;; | ||
| TRELLO_API_KEY) VALUE=$TRELLO_API_KEY ;; | ||
| TRELLO_TOKEN) VALUE=$TRELLO_TOKEN ;; | ||
| TRELLO_BOARD_ID) VALUE=$TRELLO_BOARD_ID ;; | ||
| TRELLO_LIST_ID) VALUE=$TRELLO_LIST_ID ;; | ||
| FEEDBACK_API_KEY) VALUE=$FEEDBACK_API_KEY ;; | ||
| FEEDBACK_PRODUCTION_URL) VALUE=$FEEDBACK_PRODUCTION_URL ;; | ||
| FEEDBACK_TEST_URL) VALUE=$FEEDBACK_TEST_URL ;; | ||
| COMMIT_HASH) VALUE=$COMMIT_HASH ;; | ||
| *) VALUE= ;; | ||
| esac | ||
| # Build command logic | ||
| BUILD_COMMAND="flutter build $BUILD_TARGET --no-pub --$BUILD_MODE" | ||
| # Prepare build command with feedback service credentials | ||
| BUILD_CMD="$BUILD_COMMAND" | ||
| # Add commit hash to build command | ||
| BUILD_CMD="$BUILD_CMD --dart-define=COMMIT_HASH=$COMMIT_HASH" | ||
|
|
||
| [ -n "$VALUE" ] && ENV_ARGS="$ENV_ARGS -e $VAR=$VALUE" | ||
| done | ||
| # Check and add the shared Trello board and list IDs if they are available | ||
| HAVE_TRELLO_IDS=false | ||
| if [ -n "$TRELLO_BOARD_ID" ] && [ -n "$TRELLO_LIST_ID" ]; then | ||
| HAVE_TRELLO_IDS=true | ||
| # Add these shared IDs to the build command | ||
| BUILD_CMD="$BUILD_CMD --dart-define=TRELLO_BOARD_ID=$TRELLO_BOARD_ID" | ||
| BUILD_CMD="$BUILD_CMD --dart-define=TRELLO_LIST_ID=$TRELLO_LIST_ID" | ||
| fi | ||
|
|
||
| # Add Trello feedback service variables if ALL required values are provided | ||
| if [ "$HAVE_TRELLO_IDS" = true ] && [ -n "$TRELLO_API_KEY" ] && [ -n "$TRELLO_TOKEN" ]; then | ||
| echo "Adding Trello feedback service configuration" | ||
| BUILD_CMD="$BUILD_CMD --dart-define=TRELLO_API_KEY=$TRELLO_API_KEY" | ||
| BUILD_CMD="$BUILD_CMD --dart-define=TRELLO_TOKEN=$TRELLO_TOKEN" | ||
| else | ||
| # If any Trello credential is missing, log a message but continue the build | ||
| if [ -n "$TRELLO_API_KEY" ] || [ -n "$TRELLO_TOKEN" ] || [ -n "$TRELLO_BOARD_ID" ] || [ -n "$TRELLO_LIST_ID" ]; then | ||
| echo "Warning: Incomplete Trello credentials provided. All Trello credentials must be present to include them in the build." | ||
| fi | ||
| fi | ||
|
|
||
| # Add Cloudflare feedback service variables if ALL required values are provided | ||
| # Note: Cloudflare also needs the Trello board and list IDs to be available | ||
| if [ "$HAVE_TRELLO_IDS" = true ] && [ -n "$FEEDBACK_API_KEY" ] && [ -n "$FEEDBACK_PRODUCTION_URL" ]; then | ||
| echo "Adding Cloudflare feedback service configuration" | ||
| BUILD_CMD="$BUILD_CMD --dart-define=FEEDBACK_API_KEY=$FEEDBACK_API_KEY" | ||
| BUILD_CMD="$BUILD_CMD --dart-define=FEEDBACK_PRODUCTION_URL=$FEEDBACK_PRODUCTION_URL" | ||
| else | ||
| # If any Cloudflare credential is missing, log a message but continue the build | ||
| if [ -n "$FEEDBACK_API_KEY" ] || [ -n "$FEEDBACK_PRODUCTION_URL" ] || | ||
| ([ -n "$TRELLO_BOARD_ID" ] || [ -n "$TRELLO_LIST_ID" ]); then | ||
| echo "Warning: Incomplete Cloudflare feedback credentials provided. All Cloudflare credentials and Trello board/list IDs must be present to include them in the build." | ||
| fi | ||
| fi | ||
| # Add Matomo tracking variables if ALL required values are provided | ||
| # Matomo configuration only used when both are non-empty | ||
| if [ -n "$MATOMO_URL" ] && [ -n "$MATOMO_SITE_ID" ]; then | ||
| echo "Adding Matomo tracking configuration" | ||
| BUILD_CMD="$BUILD_CMD --dart-define=MATOMO_URL=$MATOMO_URL" | ||
| BUILD_CMD="$BUILD_CMD --dart-define=MATOMO_SITE_ID=$MATOMO_SITE_ID" | ||
| else | ||
| echo "Warning: Missing Matomo parameters. Both MATOMO_URL and MATOMO_SITE_ID must be provided." | ||
| fi | ||
| # Add web-specific build arguments if the target is web | ||
| if [ "$BUILD_TARGET" = "web" ]; then | ||
| echo "Adding web-specific build arguments: --no-web-resources-cdn" | ||
| BUILD_CMD="$BUILD_CMD --no-web-resources-cdn" | ||
| fi | ||
| # Use the provided arguments for flutter build | ||
| # Build a second time if needed, as asset downloads will require a rebuild on the first attempt | ||
| docker run $PLATFORM_FLAG --rm -v ./build:/app/build \ | ||
| -v $(pwd):/app \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Quote the workspace path in
- -v $(pwd):/app \
+ -v "$(pwd)":/app \🧰 Tools🪛 Shellcheck (0.11.0)[warning] 113-113: Quote this to prevent word splitting. (SC2046) 🤖 Prompt for AI Agents |
||
| -u "$HOST_UID:$HOST_GID" \ | ||
| $ENV_ARGS \ | ||
| komodo/komodo-wallet:latest sh -c \ | ||
| "sudo chown -R komodo:komodo /app/build; flutter pub get --enforce-lockfile; flutter build web --no-pub || true; flutter build $BUILD_TARGET --config-only; flutter build $BUILD_TARGET --no-pub --dart-define=COMMIT_HASH=$COMMIT_HASH --$BUILD_MODE" | ||
| "sudo chown -R komodo:komodo /app/build; flutter pub get --enforce-lockfile; $BUILD_COMMAND || true; flutter build $BUILD_TARGET --config-only; $BUILD_CMD" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify Android SDK version consistency across configuration files.
Line 7 builds
komodo/android-sdk:35, but the PR context indicates that.docker/android-sdk.dockerfilewas updated to platform 36. Ensure the tag version is consistent across:initializeCommandin devcontainer.json🏁 Script executed:
Length of output: 181
🏁 Script executed:
Length of output: 210
🏁 Script executed:
Length of output: 2866
Update devcontainer.json initializeCommand image tag to 36.
The devcontainer is building
komodo/android-sdk:35but the Dockerfile’sANDROID_PLATFORM_VERSIONis 36.🤖 Prompt for AI Agents