Skip to content

ci(docker): clean submodules before update to fix build errors#3139

Merged
CharlVS merged 2 commits intodevfrom
patch-fix-submodules-update
Sep 16, 2025
Merged

ci(docker): clean submodules before update to fix build errors#3139
CharlVS merged 2 commits intodevfrom
patch-fix-submodules-update

Conversation

@DeckerSU
Copy link
Copy Markdown
Contributor

Added clean submodules step before git submodule update in the build script to ensure submodules are always in a clean state before checkout. This prevents local changes inside sdk (e.g. changed build_config.json from assets transformer) from blocking the update step.

Fixes: #3137

Added clean submodules step before `git submodule update` in
the build script to ensure submodules are always in a clean state
before checkout. This prevents local changes inside
`sdk` (e.g. changed build_config.json from assets transformer) from
blocking the update step.

Fixes: #3137
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch patch-fix-submodules-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DeckerSU DeckerSU linked an issue Sep 12, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 12, 2025

Visit the preview URL for this PR (updated for commit e074d2d):

https://walletrc--pull-3139-merge-f8q5zra4.web.app

(expires Mon, 22 Sep 2025 10:15:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

Copy link
Copy Markdown
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks

@CharlVS CharlVS changed the title build: clean submodules before update to fix build errors ci(docker): clean submodules before update to fix build errors Sep 15, 2025
@GLEECBTC GLEECBTC deleted a comment from cursor bot Sep 15, 2025
@CharlVS CharlVS self-requested a review September 16, 2025 12:58
@CharlVS CharlVS merged commit 970dd30 into dev Sep 16, 2025
11 of 16 checks passed
@CharlVS CharlVS deleted the patch-fix-submodules-update branch September 16, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.docker/build.sh build fails due to unclean submodules

3 participants