fix logging of apiCommitHash to output actual value instead of closure#3115
fix logging of apiCommitHash to output actual value instead of closure#3115
Conversation
Previously, when logging apiCommitHash, the code printed the function reference (e.g. Closure: () => String) instead of the actual hash value.
Example:
```
2025-8-29: 18:38:32.869T+:0:00:00.036927 [LOG] {message: INFO: MM2 API version loaded successfully - Version: 2.5.1-beta_80766b0, Commit: Closure: () => String - null, path: VersionInfoBloc, app_version: 0.9.2, mm2_version: 2.5.1-beta_80766b0, os_language: en-US, screen_size: , timestamp: 1756492712864, date: 2025-08-29 20:38:32.864631}__metadata: {appVersion: null, mm2Version: 2.5.1-beta_80766b0, appLanguage: , platform: linux Linux 6.8.0-65-generic #68~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Jul 15 18:06:34 UTC 2, osLanguage: en-US, screenSize: }
```
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 4b1f5d8): https://walletrc--pull-3115-merge-rpgp1v1b.web.app (expires Fri, 05 Sep 2025 19:26:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a logging issue where the apiCommitHash function reference was being printed instead of its actual return value.
- Fixed string interpolation to call the
apiCommitHashfunction and return its value - Ensures the commit hash is properly displayed in log messages instead of showing "Closure: () => String"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Previously, when logging
apiCommitHash, the code printed the function reference (e.g. Closure: () => String) instead of the actual hash value.Example: