Skip to content

fix logging of apiCommitHash to output actual value instead of closure#3115

Merged
CharlVS merged 1 commit intodevfrom
patch-fix-logger-3109
Aug 31, 2025
Merged

fix logging of apiCommitHash to output actual value instead of closure#3115
CharlVS merged 1 commit intodevfrom
patch-fix-logger-3109

Conversation

@DeckerSU
Copy link
Copy Markdown
Contributor

Previously, when logging apiCommitHash, the code printed the function reference (e.g. Closure: () => String) instead of the actual hash value.

Example:

2025-8-29: 18:38:32.869T+:0:00:00.036927 [LOG] {message: INFO: MM2 API version loaded successfully - Version: 2.5.1-beta_80766b0, Commit: Closure: () => String - null, path: VersionInfoBloc, app_version: 0.9.2, mm2_version: 2.5.1-beta_80766b0, os_language: en-US, screen_size: , timestamp: 1756492712864, date: 2025-08-29 20:38:32.864631}__metadata: {appVersion: null, mm2Version: 2.5.1-beta_80766b0, appLanguage: , platform: linux Linux 6.8.0-65-generic #68~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Jul 15 18:06:34 UTC 2, osLanguage: en-US, screenSize: }

Previously, when logging apiCommitHash, the code printed the function reference (e.g. Closure: () => String) instead of the actual hash value.

Example:

```
2025-8-29: 18:38:32.869T+:0:00:00.036927 [LOG] {message: INFO: MM2 API version loaded successfully - Version: 2.5.1-beta_80766b0, Commit: Closure: () => String - null, path: VersionInfoBloc, app_version: 0.9.2, mm2_version: 2.5.1-beta_80766b0, os_language: en-US, screen_size: , timestamp: 1756492712864, date: 2025-08-29 20:38:32.864631}__metadata: {appVersion: null, mm2Version: 2.5.1-beta_80766b0, appLanguage: , platform: linux Linux 6.8.0-65-generic #68~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Jul 15 18:06:34 UTC 2, osLanguage: en-US, screenSize: }
```
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch patch-fix-logger-3109

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 4b1f5d8):

https://walletrc--pull-3115-merge-rpgp1v1b.web.app

(expires Fri, 05 Sep 2025 19:26:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@CharlVS CharlVS requested review from CharlVS and Copilot August 29, 2025 20:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a logging issue where the apiCommitHash function reference was being printed instead of its actual return value.

  • Fixed string interpolation to call the apiCommitHash function and return its value
  • Ensures the commit hash is properly displayed in log messages instead of showing "Closure: () => String"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM

@CharlVS CharlVS merged commit 5e83be8 into dev Aug 31, 2025
9 of 13 checks passed
@CharlVS CharlVS deleted the patch-fix-logger-3109 branch August 31, 2025 19:24
@CharlVS CharlVS mentioned this pull request Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants