Fix wallet HD mode persistence and migration bugs#3068
Conversation
Co-authored-by: charl <charl@vanstaden.info>
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@cursor how can this be tested? |
|
I enhanced the user experience for wallet import by providing more specific mnemonic validation errors. Additionally, I refactored the
Learn more about Cursor Agents |
|
Visit the preview URL for this PR (updated for commit ce496c6): https://walletrc--pull-3068-merge-gvjprbj9.web.app (expires Thu, 21 Aug 2025 16:36:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
Remove unnecessary HD state storage in metadata in favour of letting SDK handle it.
Persist wallet HD mode after sign-in and fix incorrect mode application during legacy wallet migration.
Previously, the login flow would incorrectly force
iguanamode during legacy wallet migration if the user was not yet loaded from the SDK. Additionally, the selected wallet type was not persisted after a successful sign-in, causing HD mode changes to be lost across sessions.