Skip to content

fix(ui): close dropdown on window resize#3050

Merged
CharlVS merged 2 commits intodevfrom
codex/fix-app-freeze-on-logout-dropdown
Aug 6, 2025
Merged

fix(ui): close dropdown on window resize#3050
CharlVS merged 2 commits intodevfrom
codex/fix-app-freeze-on-logout-dropdown

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Aug 5, 2025

Summary

  • close the log-out dropdown upon window resize to prevent freeze/crash when resizing from desktop to mobile layout.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 5, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/fix-app-freeze-on-logout-dropdown

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugbot free trial expires on August 9, 2025
Learn more in the Cursor dashboard.

Co-authored-by: charl <charl@vanstaden.info>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 5, 2025

Visit the preview URL for this PR (updated for commit 3dd68a7):

https://walletrc--pull-3050-merge-rabrqcfp.web.app

(expires Tue, 12 Aug 2025 16:33:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@CharlVS CharlVS added the QA Ready for QA Testing label Aug 5, 2025
@CharlVS CharlVS requested a review from smk762 August 5, 2025 16:37
@CharlVS CharlVS self-assigned this Aug 5, 2025
@CharlVS CharlVS added the bug Something isn't working label Aug 5, 2025
Copy link
Copy Markdown
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure of the steps to replicate crash mentioned in the opening comment, so all I can say is

  • I didn't crash when resizing in web browser, and pop ups would disappear when resizing down into or out of mobile view size.
  • In web, the logout button in top right that notoriously fails after resize is now functioning as expected.
  • I didn't crash when resizing in linux desktop, and pop ups would disappear when resizing down into or out of mobile view size.

Based on this, it is assumed that the proposed changes are functioning as expected. Please advise if additional confirmation testing is required.

@CharlVS CharlVS merged commit 844683e into dev Aug 6, 2025
17 of 25 checks passed
@CharlVS CharlVS deleted the codex/fix-app-freeze-on-logout-dropdown branch August 6, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working codex QA Ready for QA Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants