-
Notifications
You must be signed in to change notification settings - Fork 250
fix(nft): implement parent coin activation for NFTs #3010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CharlVS
merged 10 commits into
dev
from
codex/add-function-to-activate-parent-coins-for-nfts
Jul 30, 2025
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a15f83b
feat(nft): tolerate activation failures
takenagain a1fc9bf
fix(nft): skip missing parents in firstWhere
takenagain 9e3029d
refactor(nft-main-repo): fix parent coin filter and use logging package
takenagain ecaa82e
fix(nft): don't return an error if there are no NFTs returned
takenagain 21ac328
fix(nft): revert map-based error responses in favor of manual activation
takenagain e4c530d
fix(skeleton-list-tile): add height constraint to fix renderflex assert
takenagain fbce539
fix(coin): temporarily skip calling deactivation RPC
takenagain c962821
Merge remote-tracking branch 'origin/dev' into codex/add-function-to-…
takenagain a76f100
fix(activation): use more complete coin conversion function
takenagain 6cee8f2
Merge remote-tracking branch 'origin/dev' into codex/add-function-to-…
takenagain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Address the unused
_disableCoinmethod and track the TODO.The commented-out deactivation logic creates technical debt. The
_disableCoinmethod is now unused (flagged by pipeline), and the TODO should be properly tracked.Consider these actions:
_disableCoinmethod since it's no longer called🏁 Script executed:
Length of output: 1188
Remove unused deactivation logic and properly track the TODO
The private method
_disableCoinis only referenced by the commented‐out block and is never invoked at runtime, and leaving both the dead code and the TODO in place creates unnecessary technical debt. Please:_disableCoin(String coinId)method definition (just below the commented block).// TODO(KDF-XXXX): revisit coin deactivation and re-enable path🤖 Prompt for AI Agents