Skip to content

fix: padding on coin details page #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CharlVS merged 2 commits into from
Jul 15, 2025
Merged

fix: padding on coin details page #2929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd5078
fix(ui): add bottom padding to coin details page
CharlVS Jul 15, 2025
e00f463
fix: various page padding fixes
CharlVS Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/views/common/pages/page_layout.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ class PageLayout extends StatelessWidget {
header: header,
content: content,
noBackground: noBackground,
padding: padding ?? PagePlate.defaultPadding,
padding: padding ?? EdgeInsets.zero,
);
}
return _DesktopLayout(
header: header,
content: content,
noBackground: noBackground,
padding: padding,
padding: padding ?? PagePlate.standardPadding,
);
}
}
Expand All @@ -40,7 +40,7 @@ class _MobileLayout extends StatelessWidget {
required this.content,
this.header,
this.noBackground = false,
this.padding = PagePlate.defaultPadding,
this.padding = PagePlate.standardPadding,
});

final Widget? header;
Expand Down Expand Up @@ -93,7 +93,7 @@ class _DesktopLayout extends StatelessWidget {
Flexible(
child: PagePlate(
noBackground: noBackground,
padding: padding ?? PagePlate.defaultPadding,
padding: padding ?? EdgeInsets.zero,
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
Expand Down
4 changes: 2 additions & 2 deletions lib/views/common/pages/page_plate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ class PagePlate extends StatelessWidget {
const PagePlate({
required this.child,
this.noBackground = true,
this.padding = defaultPadding,
this.padding = standardPadding,
super.key,
});

final Widget child;
final bool noBackground;
final EdgeInsetsGeometry padding;

static const EdgeInsets defaultPadding = EdgeInsets.fromLTRB(15, 32, 15, 0);
static const EdgeInsets standardPadding = EdgeInsets.fromLTRB(15, 32, 15, 0);

@override
Widget build(BuildContext context) {
Expand Down
5 changes: 4 additions & 1 deletion lib/views/wallet/coin_details/coin_details_info/coin_details_info.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ class _CoinDetailsInfoState extends State<CoinDetailsInfo>
.add(CoinsPubkeysRequested(widget.coin.abbr));
},
child: PageLayout(
padding: const EdgeInsets.fromLTRB(15, 32, 15, 20),
header: PageHeader(
title: widget.coin.name,
widgetTitle: widget.coin.mode == CoinMode.segwit
Expand Down Expand Up @@ -198,7 +199,8 @@ class _DesktopContent extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Container(
padding: const EdgeInsets.fromLTRB(0, 20.0, 0, 20.0),
margin: const EdgeInsets.only(top: 16),
padding: const EdgeInsets.symmetric(horizontal: 16),
decoration: BoxDecoration(
color: Theme.of(context).cardColor,
borderRadius: BorderRadius.circular(18.0),
Expand Down Expand Up @@ -246,6 +248,7 @@ class _DesktopCoinDetails extends StatelessWidget {
padding: const EdgeInsets.only(right: 8.0),
child: Column(
children: [
SizedBox(height: 16),
Row(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Expand Down
3 changes: 2 additions & 1 deletion lib/views/wallet/coin_details/withdraw_form/withdraw_form.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import 'dart:async' show Timer;

import 'package:easy_localization/easy_localization.dart';
import 'package:flutter/material.dart';
import 'package:komodo_ui_kit/komodo_ui_kit.dart';
import 'package:web_dex/generated/codegen_loader.g.dart';
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:komodo_defi_sdk/komodo_defi_sdk.dart';
Expand Down Expand Up @@ -222,7 +223,7 @@ class PreviewWithdrawButton extends StatelessWidget {
return SizedBox(
width: double.infinity,
height: 48,
child: FilledButton(
child: UiPrimaryButton(
onPressed: onPressed,
child: isSending
? const SizedBox(
Expand Down
Loading