Skip to content

Fix null my_info handling for swaps#2820

Merged
CharlVS merged 3 commits intodevfrom
codex/fix-null-parsing-in-swap-info
Jun 30, 2025
Merged

Fix null my_info handling for swaps#2820
CharlVS merged 3 commits intodevfrom
codex/fix-null-parsing-in-swap-info

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Jun 25, 2025

Summary

  • handle null my_info when parsing swaps
  • make Swap.myInfo nullable throughout the app
  • guard UI and sort logic when myInfo is absent

Testing

  • flutter pub get --offline --enforce-lockfile (fails: version solving failed)
  • flutter analyze --no-pub (fails: analysis server exit)
  • dart format -o none lib/blocs/trading_entities_bloc.dart lib/model/swap.dart lib/views/dex/dex_helpers.dart lib/views/dex/entities_list/history/history_item.dart lib/views/dex/entities_list/history/swap_history_sort_mixin.dart lib/views/dex/entities_list/in_progress/in_progress_item.dart lib/views/dex/entities_list/in_progress/in_progress_list.dart lib/views/dex/entity_details/swap/swap_details.dart lib/views/dex/entity_details/swap/swap_details_step_list.dart

https://chatgpt.com/codex/tasks/task_e_685bf1b20d988326ae4dce966bebd0e0

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jun 25, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CharlVS CharlVS requested a review from smk762 June 25, 2025 13:28
@CharlVS CharlVS self-assigned this Jun 25, 2025
@CharlVS CharlVS added the QA Ready for QA Testing label Jun 25, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 25, 2025

Visit the preview URL for this PR (updated for commit 61e3051):

https://walletrc--pull-2820-merge-cggxntm8.web.app

(expires Mon, 07 Jul 2025 14:56:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@DeckerSU
Copy link
Copy Markdown
Contributor

@CharlVS Maybe it would be a good idea to add a separate test (or tests) under test_units to deserialize the response of getMyRecentSwaps and create different test cases where my_info and other parameters are set to null. Just to be sure we cover as many of those cases as possible.

What do you think? Is it worth doing?

Copy link
Copy Markdown
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

However I just want to mention that there are plenty of places where the GUI relies on kdf. For example, if events contains null, this expression List<Map<String, dynamic>>.from(json['events']) will fail as well, etc.

Also, this isn’t related to these changes, but I noticed that in this build (not sure in which commit it was introduced earlier) on the Windows platform, if a user enters an incorrect wallet password, it doesn’t say "Invalid password" or anything similar. Instead, it responds with "Invalid parameters provided to wallet," which can be confusing. Just letting you know here - I’ll probably create a separate issue for this.

@smk762
Copy link
Copy Markdown
Collaborator

smk762 commented Jun 26, 2025

If you could please supply the steps to replicate (i.e. spawn a swap with nulls), I'm happy to confirm testing. I was unable to see a related issue which might reveal this.

Equally content to approve based on Decker's tests, as he first reported the problem and would be best placed to confirm it has been resolved.

@DeckerSU
Copy link
Copy Markdown
Contributor

I guess we can merge this into dev, since the root of the issue is now resolved and KW can correctly handle null in my_info.

@CharlVS CharlVS merged commit 883b699 into dev Jun 30, 2025
8 of 12 checks passed
@CharlVS CharlVS deleted the codex/fix-null-parsing-in-swap-info branch June 30, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex QA Ready for QA Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants