Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 61e3051): https://walletrc--pull-2820-merge-cggxntm8.web.app (expires Mon, 07 Jul 2025 14:56:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
|
@CharlVS Maybe it would be a good idea to add a separate test (or tests) under What do you think? Is it worth doing? |
DeckerSU
left a comment
There was a problem hiding this comment.
LGTM.
However I just want to mention that there are plenty of places where the GUI relies on kdf. For example, if events contains null, this expression List<Map<String, dynamic>>.from(json['events']) will fail as well, etc.
Also, this isn’t related to these changes, but I noticed that in this build (not sure in which commit it was introduced earlier) on the Windows platform, if a user enters an incorrect wallet password, it doesn’t say "Invalid password" or anything similar. Instead, it responds with "Invalid parameters provided to wallet," which can be confusing. Just letting you know here - I’ll probably create a separate issue for this.
|
If you could please supply the steps to replicate (i.e. spawn a swap with Equally content to approve based on Decker's tests, as he first reported the problem and would be best placed to confirm it has been resolved. |
|
I guess we can merge this into |
…into codex/fix-null-parsing-in-swap-info
Summary
nullmy_infowhen parsing swapsSwap.myInfonullable throughout the appmyInfois absentTesting
flutter pub get --offline --enforce-lockfile(fails: version solving failed)flutter analyze --no-pub(fails: analysis server exit)dart format -o none lib/blocs/trading_entities_bloc.dart lib/model/swap.dart lib/views/dex/dex_helpers.dart lib/views/dex/entities_list/history/history_item.dart lib/views/dex/entities_list/history/swap_history_sort_mixin.dart lib/views/dex/entities_list/in_progress/in_progress_item.dart lib/views/dex/entities_list/in_progress/in_progress_list.dart lib/views/dex/entity_details/swap/swap_details.dart lib/views/dex/entity_details/swap/swap_details_step_list.darthttps://chatgpt.com/codex/tasks/task_e_685bf1b20d988326ae4dce966bebd0e0