Skip to content

disable Firebase Analytics on Linux and explicitly handle Unsupported…#2818

Merged
CharlVS merged 2 commits intodevfrom
patch-firebase-init
Jun 30, 2025
Merged

disable Firebase Analytics on Linux and explicitly handle Unsupported…#2818
CharlVS merged 2 commits intodevfrom
patch-firebase-init

Conversation

@DeckerSU
Copy link
Copy Markdown
Contributor

…Error in init

  • Add a Platform.isLinux guard to immediately disable analytics on unsupported platforms
  • Wrap Firebase.initializeApp in its own try/catch to catch UnsupportedError and short-circuit initialization
  • Complete the _initCompleter with an error on unsupported platforms to unblock awaiting callers
  • Preserve existing retry logic for other initialization failures without retrying when unsupported
  • Log debug messages when initialization is skipped or fails due to lack of Linux support

…Error in init

* Add a `Platform.isLinux` guard to immediately disable analytics on unsupported platforms
* Wrap `Firebase.initializeApp` in its own `try/catch` to catch `UnsupportedError` and short-circuit initialization
* Complete the `_initCompleter` with an error on unsupported platforms to unblock awaiting callers
* Preserve existing retry logic for other initialization failures without retrying when unsupported
* Log debug messages when initialization is skipped or fails due to lack of Linux support
@DeckerSU DeckerSU requested a review from CharlVS June 24, 2025 23:49
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jun 24, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 24, 2025

Visit the preview URL for this PR (updated for commit 9b1434e):

https://walletrc--pull-2818-merge-vkvsg7rh.web.app

(expires Wed, 02 Jul 2025 14:49:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions.

@@ -1,5 +1,6 @@
import 'dart:convert';
import 'dart:async';
import 'dart:io';
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please instead use TargetPlatform and kIsWeb from package:flutter/foundation.dart, similar to how it's done in lib/firebase_options.dart because dart:io isn't supported on web. I'm not sure why it builds and runs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 9b1434e. Thanks for sharing best practices.

Removed import of dart:io and its `Platform.isLinux` check in AnalyticsRepo,
switching to Flutter’s cross-platform API (`kIsWeb` + defaultTargetPlatform).
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM!

@CharlVS CharlVS merged commit aa04363 into dev Jun 30, 2025
9 of 13 checks passed
@CharlVS CharlVS deleted the patch-firebase-init branch June 30, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants