hot-fix(fiat-onramp): breaking Ramp API change#2794
Conversation
undocumented change to the v1 API `enabledFlows` configuration option
WalkthroughThe changes update the value of the 'enabledFlows' key in a payload within the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (10)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 4311841): https://walletrc--pull-2794-merge-ynm0pfkx.web.app (expires Thu, 26 Jun 2025 15:17:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
Aligns the Ramp
enabledFlowsconfiguration parameter with the format expected and defined in their documentation.Although incorrect, the Ramp v1 API previously accepted (or ignored) the URL encoded string of a JavaScript array
['ONRAMP']->%5B%27ONRAMP%27%5D. A recent change to their form/API appears to have tightened up their validation, and the URL-encoded array is no longer accepted.Ramp was last tested between 07-15 May 2025 (#2608 , #2570), so this change likely occurred sometime afterwards. I couldn't locate changelogs, or PRs in their repositories documenting releases or major changes.
Note:
Summary by CodeRabbit
Bug Fixes
Chores