feat(wallet): redesign assets page for improved ux by CharlVS · Pull Request #2771 · GLEECBTC/gleec-wallet

CharlVS · 2025-06-12T16:48:21Z

Summary

This PR introduces a comprehensive redesign of the wallet assets page, implementing a tab-based navigation system and significantly improving the mobile user experience. The portfolio charts are now integrated as dedicated tabs alongside the assets list, providing a cleaner and more intuitive interface.

Changes

🎨 UI/UX Improvements

Tabbed Navigation: Replaced the overlay chart system with a clean tab structure featuring:
- Assets tab (default) - Shows user's coin holdings
- Portfolio Growth tab - Dedicated view for growth charts
- Profit & Loss tab - Separate view for P&L analysis
Mobile Enhancements:
- New statistics carousel replacing the desktop wrap layout
- Optimized coin list items with better balance/24h change display
- Platform-specific padding and spacing adjustments
Responsive Design: Improved layouts that adapt seamlessly between mobile and desktop

📊 Real-time Data Integration

Added 24h price change tracking across all wallet views
Integrated real-time balance updates with percentage changes
Enhanced PortfolioGrowthBloc to calculate and expose:
- Total portfolio balance
- 24h change in USD
- 24h percentage change

🏗️ Technical Improvements

Implemented NestedScrollView for better scroll behavior with tabs
Refactored CoinListView into a separate widget for cleaner code
Added cached price retrieval methods to avoid unnecessary API calls
Migrated CexPrice to use SDK types for better compatibility

Breaking Changes

⚠️ PortfolioGrowthChartLoadSuccess state now requires additional parameters:

totalBalance
totalChange24h
percentageChange24h

Screenshots

Testing

Tested tab navigation on mobile and desktop
Verified 24h price changes update correctly
Confirmed smooth scrolling behavior with nested scroll view
Tested statistics carousel on mobile devices
Verified backward compatibility for existing portfolio data

…d UX - Restructure wallet page with tab-based navigation (Assets, Portfolio Growth, Profit & Loss) - Replace single scroll view with NestedScrollView for better tab content management - Move portfolio charts from overlay to dedicated tabs for clearer organization - Enhance mobile coin list items with dedicated balance/24h change layout - Add statistics carousel for mobile wallet overview replacing wrap layout - Integrate 24h price tracking across coin items and portfolio calculations - Update wallet overview with real-time balance and copy functionality - Improve responsive design with platform-specific padding and layouts - Refactor CoinListView into separate widget for cleaner code structure - Change "Currency" header to "Portfolio" and update action button text BREAKING CHANGE: PortfolioGrowthChartLoadSuccess state now requires totalBalance, totalChange24h, and percentageChange24h parameters

coderabbitai · 2025-06-12T16:48:27Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-12T16:52:16Z

Visit the preview URL for this PR (updated for commit d823536):

https://walletrc--pull-2771-merge-gc9nwwwi.web.app

_{(expires Thu, 19 Jun 2025 16:52:10 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

smk762 · 2025-06-12T21:00:51Z

For negative values, it seems the plot line hugs the bottom border. Can we extend the y axis range a little in this case to list it some?

Related issue: #2762 (same numbers in img above, though they calmed down shortly after)

ca333

sec code reviewed

smk762

Confirmed #2762 to be addressed in future PR.

Currently unable to test mobile due to IPv6 issue, but will once KDF version with fix is in wallet.

CharlVS requested review from DeckerSU and smk762 June 12, 2025 16:49

CharlVS self-assigned this Jun 12, 2025

CharlVS changed the title ~~feat(wallet): redesign assets page with tabbed navigation and improve…~~ feat(wallet): redesign assets page for improved ux Jun 12, 2025

This comment was marked as duplicate.

Sign in to view

ca333 approved these changes Jun 12, 2025

View reviewed changes

smk762 approved these changes Jun 13, 2025

View reviewed changes

CharlVS merged commit c0cd153 into release/hot-fix-trezor-login Jun 13, 2025
9 of 12 checks passed

CharlVS deleted the fix/wallet-page-ui-design-fixes branch June 20, 2025 17:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(wallet): redesign assets page for improved ux#2771

feat(wallet): redesign assets page for improved ux#2771
CharlVS merged 1 commit intorelease/hot-fix-trezor-loginfrom
fix/wallet-page-ui-design-fixes

CharlVS commented Jun 12, 2025

Uh oh!

coderabbitai bot commented Jun 12, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

smk762 commented Jun 12, 2025 •

edited

Loading

Uh oh!

This comment was marked as duplicate.

Uh oh!

ca333 left a comment

Uh oh!

smk762 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

CharlVS commented Jun 12, 2025

Summary

Changes

🎨 UI/UX Improvements

📊 Real-time Data Integration

🏗️ Technical Improvements

Breaking Changes

Screenshots

Testing

Uh oh!

coderabbitai bot commented Jun 12, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

smk762 commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

ca333 left a comment

Choose a reason for hiding this comment

Uh oh!

smk762 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)

smk762 commented Jun 12, 2025 •

edited

Loading