Skip to content

build: upgrade Flutter references to 3.32.2 and lower JDK target to 17#2759

Merged
CharlVS merged 9 commits intodevfrom
codex/update-flutter-version-and-dependencies
Jun 12, 2025
Merged

build: upgrade Flutter references to 3.32.2 and lower JDK target to 17#2759
CharlVS merged 9 commits intodevfrom
codex/update-flutter-version-and-dependencies

Conversation

@takenagain
Copy link
Copy Markdown
Contributor

@takenagain takenagain commented Jun 10, 2025

Summary

  • Update Flutter SDK requirement to 3.32.2
  • Switch GitHub actions to Flutter 3.32.2
  • Upgrade SDK to 27683558605b58387cf22e15fa06c29ecb62edb6 to lower JDK requirement to 17.
  • Upgrade http package to 1.4.0
  • Add workflow to build Android APK via docker to ensure that the build image and flow is functional.
  • Mount project as volume in build.sh instead of doing it in the image

https://chatgpt.com/codex/tasks/task_e_6847eadbdf888331a91256097e70351b

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jun 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@takenagain takenagain self-assigned this Jun 10, 2025
@takenagain takenagain marked this pull request as draft June 10, 2025 09:18
@takenagain takenagain changed the title Update Flutter references and Docker JDK build: update Flutter references and Android Docker JDK Jun 10, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 10, 2025

Visit the preview URL for this PR (updated for commit 1864eda):

https://walletrc--pull-2759-merge-e30i94f8.web.app

(expires Tue, 17 Jun 2025 19:07:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@takenagain takenagain changed the title build: update Flutter references and Android Docker JDK build: upgrade Flutter references to 3.32.2 and lower JDK target to 17 Jun 10, 2025
@takenagain takenagain force-pushed the codex/update-flutter-version-and-dependencies branch from e99af83 to 29aa733 Compare June 10, 2025 16:59
@takenagain takenagain marked this pull request as ready for review June 10, 2025 19:22
@takenagain takenagain requested review from CharlVS and DeckerSU June 10, 2025 19:22
Copy link
Copy Markdown
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent. It not only resolves the issues mentioned in #2756, but also addresses the TODO noted in #2693 (comment) regarding mounting sources as a volume.

Overall, perfect. Thank you!

@smk762
Copy link
Copy Markdown
Collaborator

smk762 commented Jun 11, 2025

I still have issues with local android builds.
Major issue appears to be

I/flutter (19989): Loaded library at path: libkomodo_defi_framework.so
I/flutter (19989): 11 05:23:16, common:527] panicked at 'Valid domain viserion.dragon-seed.com: ip_addr:203] Address/Seed viserion.dragon-seed.com resolved to IPv6 which is not supported', mm2src/mm2_p2p/src/network.rs:74:82
...
I/flutter (19989): 11 05:23:16, common:527] panicked at 'Fatal error on starting gossipsub: Canceled', /var/lib/jenkins/workspace/komodo-defi-framework-android/mm2src/mm2_p2p/src/behaviours/atomicdex.rs:1247:21

More detailed logs below:

A Dart VM Service on SM G990E is available at: http://127.0.0.1:45865/R3gQrR6MMJk=/
...
E/gralloc4(19989): ERROR: Format allocation info not found for format: 38
E/gralloc4(19989): ERROR: Format allocation info not found for format: 0
E/gralloc4(19989): Invalid base format! req_base_format = 0x0, req_format = 0x38, type = 0x0
E/gralloc4(19989): ERROR: Unrecognized and/or unsupported format 0x38 and usage 0xb00
E/Gralloc4(19989): isSupported(1, 1, 56, 1, ...) failed with 5
E/GraphicBufferAllocator(19989): Failed to allocate (4 x 4) layerCount 1 format 56 usage b00: 5
E/AHardwareBuffer(19989): GraphicBuffer(w=4, h=4, lc=1) failed (Unknown error -5), handle=0x0
E/gralloc4(19989): ERROR: Format allocation info not found for format: 3b
E/gralloc4(19989): ERROR: Format allocation info not found for format: 0
E/gralloc4(19989): Invalid base format! req_base_format = 0x0, req_format = 0x3b, type = 0x0
E/gralloc4(19989): ERROR: Unrecognized and/or unsupported format 0x3b and usage 0xb00
E/Gralloc4(19989): isSupported(1, 1, 59, 1, ...) failed with 5
E/GraphicBufferAllocator(19989): Failed to allocate (4 x 4) layerCount 1 format 59 usage b00: 5
E/AHardwareBuffer(19989): GraphicBuffer(w=4, h=4, lc=1) failed (Unknown error -5), handle=0x0
E/gralloc4(19989): ERROR: Format allocation info not found for format: 38
E/gralloc4(19989): ERROR: Format allocation info not found for format: 0
E/gralloc4(19989): Invalid base format! req_base_format = 0x0, req_format = 0x38, type = 0x0
E/gralloc4(19989): ERROR: Unrecognized and/or unsupported format 0x38 and usage 0xb00
E/Gralloc4(19989): isSupported(1, 1, 56, 1, ...) failed with 5
E/GraphicBufferAllocator(19989): Failed to allocate (4 x 4) layerCount 1 format 56 usage b00: 5
E/AHardwareBuffer(19989): GraphicBuffer(w=4, h=4, lc=1) failed (Unknown error -5), handle=0x0
E/gralloc4(19989): ERROR: Format allocation info not found for format: 3b
E/gralloc4(19989): ERROR: Format allocation info not found for format: 0
E/gralloc4(19989): Invalid base format! req_base_format = 0x0, req_format = 0x3b, type = 0x0
E/gralloc4(19989): ERROR: Unrecognized and/or unsupported format 0x3b and usage 0xb00
E/Gralloc4(19989): isSupported(1, 1, 59, 1, ...) failed with 5
E/AHardwareBuffer(19989): GraphicBuffer(w=4, h=4, lc=1) failed (Unknown error -5), handle=0x0
I/flutter (19989): Loaded library at path: libkomodo_defi_framework.so
I/flutter (19989): Error getting KDF version: ClientException with SocketException: Connection refused (OS Error: Connection refused, errno = 111), address = localhost, port = 45282, uri=http://localhost:7783
I/flutter (19989): KDF is not running.

...

I/flutter (19989): Error getting KDF version: ClientException with SocketException: Connection refused (OS Error: Connection refused, errno = 111), address = localhost, port = 45288, uri=http://localhost:7783
I/flutter (19989): KDF is not running.
I/flutter (19989): Error getting KDF version: ClientException with SocketException: Connection refused (OS Error: Connection refused, errno = 111), address = localhost, port = 45298, uri=http://localhost:7783
I/flutter (19989): KDF is not running.
I/flutter (19989): Starting KDF main...
I/flutter (19989): Loaded library at path: libkomodo_defi_framework.so
I/flutter (19989): 11 05:23:16, common:527] panicked at 'Valid domain viserion.dragon-seed.com: ip_addr:203] Address/Seed viserion.dragon-seed.com resolved to IPv6 which is not supported', mm2src/mm2_p2p/src/network.rs:74:82
I/flutter (19989): 11 05:23:16, common:528] backtrace
I/flutter (19989):   ??:0] _ZL15__pthread_startPv 0x7ad9ef888b
I/flutter (19989):   ??:0] __start_thread 0x7ad9e95373
I/flutter (19989): 11 05:23:16, common:527] panicked at 'Fatal error on starting gossipsub: Canceled', /var/lib/jenkins/workspace/komodo-defi-framework-android/mm2src/mm2_p2p/src/behaviours/atomicdex.rs:1247:21
I/flutter (19989): 11 05:23:16, common:528] backtrace
I/flutter (19989): Closure: (_KdfMainParams) => int from Function '_kdfMainIsolate@2399206786': static.nceled")
I/flutter (19989): KDF started in 1642ms
I/flutter (19989): Error getting KDF version: ClientException with SocketException: Connection refused (OS Error: Connection refused, errno = 111), address = localhost, port = 40092, uri=http://localhost:7783
I/flutter (19989): KDF is not running.

@smk762
Copy link
Copy Markdown
Collaborator

smk762 commented Jun 11, 2025

KDF fix for this under review: https://github.com/KomodoPlatform/komodo-defi-framework/pull/2487/files

I'll need a mobile build (or branch I can build from with correct SDK refs) to test this fix.

@smk762 smk762 self-requested a review June 11, 2025 12:06
Copy link
Copy Markdown
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this will build - the error I faced happens later - and is fixed by GLEECBTC/komodo-defi-framework#2487

@CharlVS CharlVS merged commit ee79c1d into dev Jun 12, 2025
10 of 14 checks passed
@CharlVS CharlVS deleted the codex/update-flutter-version-and-dependencies branch June 20, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Android app can't be built via .docker/build.sh ... JDK incompatibility.

4 participants