build: upgrade Flutter references to 3.32.2 and lower JDK target to 17#2759
build: upgrade Flutter references to 3.32.2 and lower JDK target to 17#2759
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 1864eda): https://walletrc--pull-2759-merge-e30i94f8.web.app (expires Tue, 17 Jun 2025 19:07:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
e99af83 to
29aa733
Compare
DeckerSU
left a comment
There was a problem hiding this comment.
Looks excellent. It not only resolves the issues mentioned in #2756, but also addresses the TODO noted in #2693 (comment) regarding mounting sources as a volume.
Overall, perfect. Thank you!
|
I still have issues with local android builds. More detailed logs below: |
|
KDF fix for this under review: https://github.com/KomodoPlatform/komodo-defi-framework/pull/2487/files I'll need a mobile build (or branch I can build from with correct SDK refs) to test this fix. |
smk762
left a comment
There was a problem hiding this comment.
I can confirm this will build - the error I faced happens later - and is fixed by GLEECBTC/komodo-defi-framework#2487
Summary
27683558605b58387cf22e15fa06c29ecb62edb6to lower JDK requirement to 17.httppackage to1.4.0build.shinstead of doing it in the imagehttps://chatgpt.com/codex/tasks/task_e_6847eadbdf888331a91256097e70351b