feat(auth): SDK password update migration

[CharlVS]

Re-implement password update functionality using the recently added KDF RPC. This is necessary because the Flutter app no longer handles authentication and user accounts and is managed by KDF (exposed through the SDK)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Visit the preview URL for this PR (updated for commit 02c60df):

https://walletrc--pull-2580-merge-p0d6ifii.web.app

_{(expires Wed, 23 Apr 2025 10:14:13 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

[smk762]

To Test:

• create or import a wallet
• change the password
• log out
• confirm login with old password fails
• confirm login with new password succeeds
• export wallet to file
• log out
• clear cache, and import recently exported wallet file
• confirm old password fails
• confirm new password works

@CharlVS please add any extras I've not covered.

[smk762]

Ambiguous error message:

This was triggered when I input an incorrect "old password".

Other validation cases for matching / compliant "new password / confirm new password" inputs function as expected with informative error messaging.

The heading for this step implies an action not yet completed. Suggest change to Importing seed file

I've opened a separate issue for allowing import of files with existing wallet name to allow rename.

Otherwise the feature functions as expected 👍

[CharlVS]

The heading for this step implies an action not yet completed. Suggest change to Importing seed file

@TazzyMeister Please address this in your PR #2587. It may require creating a new locale value if the other references use it correctly.

[CharlVS]

To Test:

• create or import a wallet
• change the password
• log out
• confirm login with old password fails
• confirm login with new password succeeds
• export wallet to file
• log out
• clear cache, and import recently exported wallet file
• confirm old password fails
• confirm new password works

@CharlVS please add any extras I've not covered.

@smk762 that looks good. It goes beyond everything needed, but it's better to be safe since a funky state in KDF after password updates could be disastrous. The GUI changes are limited to the re-introduction of password updates (which is not stored by KW), so anything beyond that is testing for KDF.

[smk762]

LGTM, thanks!

[AndrewDelaney]

When attempting password change, if I set all three values to be the same new password I'm trying to set, this is the error message I reveive:

In this case it should be an "Incorrect current password" error message

[ShantanuSharma9873]

@CharlVS Was tested and can confirmed as Fixed 👍️