Conversation
Lined up headers with coin details and fixed extra padding with 24H
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request updates two components: the Changes
Sequence Diagram(s)Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Lined up headers with coin details and fixed extra padding with 24H
…zyMeister/komodo-wallet into fix/align-walletpage-headers
…into add/assets-list-rework
Lined up the headers that it fits the list of coins better by changing the ratio.
|
@smk762, when @TazzyMeister tags you in this PR that this is ready for review, please check that:
|
…nto fix/align-walletpage-headers
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
firebase.json(1 hunks)lib/views/wallet/wallet_page/common/coins_list_header.dart(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: Test web-app-macos
- GitHub Check: Test web-app-linux-profile
- GitHub Check: Build Desktop (linux)
- GitHub Check: Build Mobile (Android)
- GitHub Check: unit_tests
- GitHub Check: Build Desktop (windows)
- GitHub Check: validate_code_guidelines
- GitHub Check: Build Mobile (iOS)
- GitHub Check: Build Desktop (macos)
🔇 Additional comments (5)
firebase.json (1)
3-3: Firebase hosting site updated.The site identifier has been changed from "walletrc" to "wallet-rc-device-preview", which suggests this is now targeting a new Firebase Hosting site specifically configured for device preview of the wallet release candidate.
Ensure this new Firebase Hosting site has been properly configured in your Firebase project to prevent deployment failures.
lib/views/wallet/wallet_page/common/coins_list_header.dart (4)
83-89: Improved layout structure with Expanded widgets.Replacing direct Text widgets with Expanded widgets provides better layout control and responsiveness, addressing the column alignment objective mentioned in the PR.
91-98: New Price header with appropriate flex value.Good addition of a dedicated Price header with a flex value of 2, which helps maintain proper spacing and alignment with the coin information below.
101-107: Improved 24h change header alignment.Converting the previous fixed-width Container to an Expanded widget with flex: 2 addresses the excessive padding issue mentioned in the PR objectives.
119-122: Good use of ConstrainedBox for expand button space.Using ConstrainedBox with a minimum width constraint ensures consistent space for the expand button regardless of screen size.
| // Chart header | ||
| Expanded( | ||
| flex: 2, | ||
| child: Text( | ||
| LocaleKeys.price.tr(), | ||
| style: style, | ||
| ), | ||
| ), |
There was a problem hiding this comment.
Incorrect label text for Chart header.
The Chart header is using the same localization key as the Price header (LocaleKeys.price.tr()), which would display "Price" instead of "Chart".
- child: Text(
- LocaleKeys.price.tr(),
- style: style,
- ),
+ child: Text(
+ LocaleKeys.chart.tr(), // Or create a new localization key if needed
+ style: style,
+ ),📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // Chart header | |
| Expanded( | |
| flex: 2, | |
| child: Text( | |
| LocaleKeys.price.tr(), | |
| style: style, | |
| ), | |
| ), | |
| // Chart header | |
| Expanded( | |
| flex: 2, | |
| child: Text( | |
| LocaleKeys.chart.tr(), // Or create a new localization key if needed | |
| style: style, | |
| ), | |
| ), |
…tform/komodo-wallet into fix/align-walletpage-headers
It was showing price instead of chart as the header for the asset list.
|
|
@smk762 Please create an issue (and tag |
@smk762 please re-test this. It should ™ be resolved with the changes merged from |
…into fix/align-walletpage-headers
@smk762, scratch that. I see it was intentionally removed because that's what the designs called for. In hindsight, it doesn't make sense, but we can revisit it shortly after the release. 
|
@smk762, same as my previous comment. The font size is as specc'd in the designs, but it's not ideal . I've added the app-wide typography review to my post-release priority items |
smk762
left a comment
smk762
left a comment
There was a problem hiding this comment.
Well, I guess saying "LGTM" would be a lie, but if it looks like the spec it seems the only items blocking my approval are not valid. I look forward to the "post-release review" and restoration of these columns.
4 participants
Lined up headers with coin details and fixed extra padding with 24H
Summary by CodeRabbit