Merged
Conversation
Collaborator
Collaborator
|
if i just check "use date sync" and keep the date same it starts from after restart, overwriting the existing DB checked all cases with "If prior cache exists", the last 3 ones... working as expected |
cipig
previously approved these changes
Sep 21, 2023
Collaborator
cipig
left a comment
There was a problem hiding this comment.
all 5 cases work as expected
thanks for the fix
borngraced
approved these changes
Sep 21, 2023
The merge-base changed after approval.
cipig
reviewed
Sep 24, 2023
cipig
previously approved these changes
Oct 1, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tests the dev branch API with includes GLEECBTC/komodo-defi-framework#1967
For syncing ARRR, the following cases apply:
use_dateif off, sync starts 2 days in the past.use_dateif on, sync starts on block height derived from date (rounded to nearest 1000).use_dateif off, sync continues from prior cache height.use_dateif on, and date value has changed since last sync, sync starts on block height derived from date (rounded to nearest 1000).use_dateif on, and date value has not changed since last sync, sync continues from prior cache height.To test: