Merged
Conversation
CharlVS
approved these changes
Oct 18, 2024
|
bear in mind though that GUIs would need to include |
Collaborator
|
Problem is this from utils/coins_config_tcp.json so mm2 will connect to electrum1 twice, with TCP and with SSL |
cipig
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, coins with more than 3 electrums would have this sliced down to just 3 active. In light of GLEECBTC/komodo-defi-framework#1966 this limit is better handled in the kdf/app layer.
Additionally, the
nodes,rpc_urlsandelectrumsvalues for coins in thecoins_config.jsonoutput are sorted alphabetically (by theurlkey) - this will help avoid "diff inflation" from new PRs where only the sequence of spv server objects has changed.