Skip to content

Prepare plugin for Qt6#314

Merged
merydian merged 39 commits intomainfrom
feat/qt6
May 16, 2025
Merged

Prepare plugin for Qt6#314
merydian merged 39 commits intomainfrom
feat/qt6

Conversation

@merydian
Copy link
Collaborator

@merydian merydian commented May 12, 2025

Supersedes #290 and #250. Closes #272 and #303.

merydian and others added 26 commits May 12, 2025 10:19
@merydian
refactor: run pyqt5_to_pyqt6.py migration script
7912c88
@merydian
feat: add gui utils
3ad44c4
@merydian
feat: add necessary metadata note for qt6 conformance
f781468
@merydian
feat: load main gui ui file as needed for qt6
c590c00
@merydian
fix: replace old import statement
ea99ee3
@merydian
feat: import ui file like expected in PyQt6
241212d
@merydian
fix: add main plugin items like expected in PyQt6
cee35e6
@merydian
fix: display utility button icons
2bcbf85
@merydian
fix: make provider window work again
fab63f3
@merydian
fix: make processing icon appear agein
2637088
@merydian
style: run ruff
fe73f21
@merydian
style: delete UI.py files
25a14fb
@merydian
style: delete resource files
b7faf16
@merydian
fix: remove duplicate method definition
dfc328a
@merydian
fix: specify new path of Qt cursorhand form definition
37753e9
@merydian
fix: specify new path of Qt clicks
0a4b66d
@merydian
fix: remove unnecessary method definition
398c2b7
@merydian
fix: import gui
c7a5b5b
@merydian
fix: coloring of duplicate items in qlistwidget
40b5b90
@merydian
fix: switch from QVariant to QMetaType
11347e6
@merydian
style: run ruff
7859918
@merydian
fix: wrong path ov save vertices icon
4f3d3c4
@merydian
fix: remove duplicate :: in .ui file
7956675
@merydian
fix: introduce wrapper class for QgsField
510d3bf 
QgsField expects QVariant in QGIS versins <303800, else QMetaType
@merydian
style: run ruff
6b17e72
@merydian
fix: use xvfb-run correctly without DISPLAY override to prevent GUI t…
25f5b13 
…est crashes
@merydian merydian marked this pull request as ready for review May 12, 2025 13:46
MichaelsJP
MichaelsJP requested changes May 13, 2025
View reviewed changes
@MichaelsJP
Copy link
Member

MichaelsJP commented May 13, 2025

LGTM. Just a few minor things.

@MichaelsJP
Copy link
Member

MichaelsJP commented May 13, 2025 •
edited
Loading

  • (Prio) When starting fresh without an API Key creating points with live preview fails. Of course. But it should be caught with showing a sensible message to the user.
  • No numbers visible in the layer point popup.
  • (Minor) Just noticed when moving the points that the points disappear while moving. They are visible again when releasing. Has low priority, I think.
  • (Prio) Travelling salesman needs three points and currently the plugin throws an exception when only two are set.

My specs

QGIS version3.42.2-Münster
QGIS code branchRelease 3.42
 
Libraries
Qt version5.15.16
Python version3.13.3
GDAL version3.10.2 (Compiled)
3.10.3 (Running)
PROJ version9.6.0
EPSG Registry database versionv12.004 (2025-03-02)
GEOS version3.13.1-CAPI-1.19.2
SQLite version3.49.1 (Compiled)
3.49.2 (Running)
PDAL version2.8.3
PostgreSQL client version17.4
SpatiaLite version5.1.0
QWT version6.3.0
QScintilla2 version2.14.1
OS versionEndeavourOS
 
Active Python plugins
MetaSearch0.3.6
grassprovider2.12.99
db_manager0.1.20
processing2.12.99
ORStools1.10.0

This was referenced May 13, 2025
Open
Closed
@merydian merydian requested a review from MichaelsJP May 13, 2025 12:18
MichaelsJP
MichaelsJP requested changes May 13, 2025
View reviewed changes
Copy link
Member

@MichaelsJP MichaelsJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some tests and it's ready imo.

@merydian merydian force-pushed the feat/qt6 branch 2 times, most recently from 1948cc2 to 795a61a Compare May 13, 2025 13:47
@merydian merydian requested a review from MichaelsJP May 16, 2025 10:38
MichaelsJP
MichaelsJP approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@MichaelsJP MichaelsJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merydian merydian merged commit 1e86398 into main May 16, 2025
8 of 14 checks passed
@merydian merydian mentioned this pull request May 19, 2025
Closed
@koebi koebi deleted the feat/qt6 branch June 27, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelsJP MichaelsJP MichaelsJP approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

QgsField constructor is deprecated

2 participants

@merydian @MichaelsJP