Allow endpoint configuration for processing algorithms #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
merydian
commented
Mar 3, 2025
merydian
commented
merydian
changed the title
koebi
requested changes
May 8, 2025
Collaborator
koebi
left a comment
koebi
left a comment
There was a problem hiding this comment.
I'd suggest a "Reset to public API" and "Reset to public endpoints" button instead of the "Reset" button.
Maybe grouped as "Reset to public API" and then a "Reset URL" and "Reset Endpoints" button.
People can delete providers themselves, and new providers could be re-set as well.
Collaborator
|
|
merydian
force-pushed
the
allow_endpoint_configuration
branch
from
877e2c4 to
263ad74
Compare
koebi
reviewed
May 9, 2025
Collaborator
koebi
left a comment
koebi
left a comment
There was a problem hiding this comment.
LGTM.
What could be tested is setting and re-setting a URL and endpoint config, ideally with a request using the set and re-set config values?
merydian
force-pushed
the
allow_endpoint_configuration
branch
2 times, most recently
from
2a368c5 to
be6d7c7
Compare
koebi
approved these changes
May 9, 2025
Co-authored-by: Jakob Schnell <[email protected]>
Co-authored-by: Jakob Schnell <[email protected]>
merydian
force-pushed
the
allow_endpoint_configuration
branch
from
2688fb8 to
3d801ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.