DAG environment #26
Draft
DAG environment #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristandeleu
commented
Mar 29, 2023
Comment on lines
+100
to
+103
| # TODO: The update of the transitive closure of the graphs | ||
| # (required to get the forward masks) depends on the last action | ||
| # applied. Reference: https://github.com/tristandeleu/jax-dag-gflownet/blob/53350bbfba3ab24f9ffa8196a3de42f139d9c5cc/dag_gflownet/env.py#L112-L116 | ||
| self._closure_T = self._closure_T |
There was a problem hiding this comment.
@saleml The update of the tensor necessary for computing the forward masks (_closure_T) depends on the last action applied (the one that led to the current state). We could implement it by keeping track of the last state inside the state object and reconstructing the action this way, but there may be a cleaner way to do that.
There was a problem hiding this comment.
Thanks, I'm looking into it now
|
@tristandeleu I know this is quite old work but I would like to work on getting it into I need to do some work to align this with our new streamlined API in any case. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A WIP implementation of the DAG environment from DAG-GFlowNet.