Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore to remove GEOSgcm_GridComp references #30

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Apr 11, 2024

Remove GEOSgcm_GridComp references in .gitignore.
(Minimal cleanup from #27.)

Remove `GEOSgcm_GridComp` references in `.gitignore`
@mathomp4 mathomp4 added the Skip Changelog Skips the Changelog Enforcer label Apr 11, 2024
@mathomp4 mathomp4 self-assigned this Apr 11, 2024
@mathomp4 mathomp4 requested a review from a team as a code owner April 11, 2024 18:47
@mathomp4 mathomp4 added 0-diff 0-diff trivial very, very obvious 0-diff change and removed 0-diff labels Apr 11, 2024
@mathomp4
Copy link
Member Author

Ahh. That was a subtle thing. The CI failed because it found an ancient branch called mathomp4-patch-1 on GEOSgcm_GridComp. So old, the interfaces were not compatible. I've removed that branch from GEOSgcm_GridComp, so now all should work.

@gmao-rreichle
Copy link
Collaborator

Ahh. That was a subtle thing. The CI failed because it found an ancient branch called mathomp4-patch-1 on GEOSgcm_GridComp. So old, the interfaces were not compatible. I've removed that branch from GEOSgcm_GridComp, so now all should work.

Thanks! But why would a GEOSgcm_GridComp branch other than develop have anything to do with this PR? Shouldn't CI use the branch that's listed in components.yaml of GEOSldas ? I'm probably missing something, and if it works I'm not going to question it further.

@gmao-rreichle gmao-rreichle merged commit 83089f5 into develop Apr 11, 2024
23 of 25 checks passed
@gmao-rreichle gmao-rreichle deleted the mathomp4-patch-1 branch April 11, 2024 23:10
@mathomp4
Copy link
Member Author

Ahh. That was a subtle thing. The CI failed because it found an ancient branch called mathomp4-patch-1 on GEOSgcm_GridComp. So old, the interfaces were not compatible. I've removed that branch from GEOSgcm_GridComp, so now all should work.

Thanks! But why would a GEOSgcm_GridComp branch other than develop have anything to do with this PR? Shouldn't CI use the branch that's listed in components.yaml of GEOSldas ? I'm probably missing something, and if it works I'm not going to question it further.

This is my attempt to support multi-repo PRs. What the CI does is after cloning look for branches in other repos with the same name. If a user does that and they are dependent, then the CI will build instead of fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff trivial very, very obvious 0-diff change Skip Changelog Skips the Changelog Enforcer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants