Move GEOSldas.F90 to use fArgParse #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Thanks, @mathomp4! Looks good to me. @biljanaorescanin, please test when you get a chance, just to be safe. It doesn't look like we'll need the full set of LDAS tests. If this works for one of the Intel [or GNU] tests, it should work for all of them. So maybe just run LDAS_CONUS and LDAS_GNUCONUS. Thanks. |
|
We passed tests. |
gmao-rreichle
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves GEOSldas.F90 to use fArgParse instead of FLAP. In MAPL 3, FLAP support will be removed, but we can transition to fArgParse now that we use Baselibs 7.13.0.
This is similar to PRs made for other executables (see GEOS-ESM/GEOSgcm_App#441)
This should work, though I'm sure @biljanaorescanin will test. But this isn't a critical fix, but we might as well transition from FLAP sooner rather than later.
Note: fArgParse doesn't (yet?) support the description and author fields when making the CLI.