Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script to compress bit-shaved netcdf output #526

Merged
merged 7 commits into from
Feb 16, 2022
Merged

Script to compress bit-shaved netcdf output #526

merged 7 commits into from
Feb 16, 2022

Conversation

gmao-rreichle
Copy link
Contributor

This PR adds a utility to compress bit-shaved netcdf output.

Original version provided by @gmao-qliu, lightly edited by @gmao-rreichle.

@weiyuan-jiang: Please review and add multi-threading capability.

@gmao-rreichle gmao-rreichle added 0-diff trivial very, very obvious 0-diff change post-processing labels Feb 9, 2022
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner February 9, 2022 16:47
@gmao-rreichle gmao-rreichle marked this pull request as draft February 11, 2022 02:58
@weiyuan-jiang
Copy link
Contributor

@gmao-qliu , I thought we can use the same name as input and output. Can you test my changes?

@gmao-qliu
Copy link
Contributor

it's unsafe to use the same name for input and output according to the nco user guide.

@weiyuan-jiang
Copy link
Contributor

it's unsafe to use the same name for input and output according to the nco user guide.

I think nco internally did the same thing as you did.

@gmao-rreichle
Copy link
Contributor Author

it's unsafe to use the same name for input and output according to the nco user guide.

I think nco internally did the same thing as you did.

@gmao-qliu: Is it ok with you to use the same file name going into and out of ncks?

@gmao-qliu
Copy link
Contributor

It's fine with me. Seems it's only unsafe with the --no_tmp_fi flag. @gmao-rreichle @weiyuan-jiang

@gmao-rreichle
add'l mods for utility script to compress bit-shaved output:
53b333a 
- added documentation (README.OutputSpecs.md)
- removed default multi-threading, added comments (compress_bit-shaved_nc4.sh)
- added comments in HISTORY template (GEOSldas_HIST.rc)
@gmao-rreichle gmao-rreichle marked this pull request as ready for review February 16, 2022 23:31
@gmao-rreichle
Copy link
Contributor Author

@weiyuan-jiang, @biljanaorescanin: I've finished my modifications of this PR but I can't approve it because I initiated it. When you get a chance, please approve and merge, or let me know if you have any concerns.

@gmao-rreichle gmao-rreichle merged commit 04ed695 into develop Feb 16, 2022
@gmao-rreichle gmao-rreichle deleted the feature/rreichle/compress_nc_script branch February 16, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiyuan-jiang weiyuan-jiang weiyuan-jiang left review comments

@biljanaorescanin biljanaorescanin biljanaorescanin approved these changes

Assignees

@weiyuan-jiang weiyuan-jiang

Labels
0-diff trivial very, very obvious 0-diff change post-processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmao-rreichle @weiyuan-jiang @gmao-qliu @biljanaorescanin