Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove catchincr grid comp when it is not land_assim #505

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Jan 3, 2022

UPDATED by @gmao-rreichle:
This PR fixes a problem reported by @gmao-qliu on 3 Jan 2022:
When GEOSldas v17.10.0 is used to write out L-band Tb data in a single-member simulation without perturbations and without data assimilation (ie, land_assim=no), the run crashes during MAPL_GenericInitialize() in the LandAssim GridComp (when the mwRTM parameters are read from the restart file). There is no crash when v17.10.0 is used in an ensemble data assimilation configuration.

The single-member, no assimilation configuration with Tb output is needed for the SMAP Nature Run (e.g., NR5000) that is delivered to the SMAP Project at JPL. The last tag for which this is known to work is v17.9.0-beta.8 (currently used for NR5000).


@saraqzhang Would you please verify this PR for me? The question here is if there exists such scenario that it is not land_assim but needs catchincr grid comp?

@saraqzhang
Copy link
Contributor

@weiyuan-jiang If not land_assim , no analysis increments will be produced. I don't think catchincr gc is needed in that no assim mode.

@gmao-rreichle
Copy link
Contributor

@weiyuan-jiang,
I agree with @saraqzhang that we shouldn't need the CatchIncr GridComp if land_assim==false.
To be safe, though, I think @biljanaorescanin should test the PR.
Also, is this PR related to the error that @gmao-qliu reported to me today (ie, MAPL_GenericInitialize() for the Landassim GC fails if land_assim==false, in case we just want to export Tb but not do Tb data assimilation)?

@gmao-qliu gmao-qliu closed this Jan 3, 2022
@gmao-qliu
Copy link
Contributor

@weiyuan-jiang, I agree with @saraqzhang that we shouldn't need the CatchIncr GridComp if land_assim==false. To be safe, though, I think @biljanaorescanin should test the PR. Also, is this PR related to the error that @gmao-qliu reported to me today (ie, MAPL_GenericInitialize() for the Landassim GC fails if land_assim==false, in case we just want to export Tb but not do Tb data assimilation)?

@gmao-qliu gmao-qliu reopened this Jan 3, 2022
@gmao-qliu
Copy link
Contributor

I believe this is related to the issue that I reported today.

@biljanaorescanin
Copy link
Contributor

All tests have passed.

@gmao-rreichle gmao-rreichle merged commit 8ef1476 into develop Jan 5, 2022
@gmao-rreichle gmao-rreichle deleted the bugfix/wjiang/rm_cathincr branch January 5, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants