remove catchincr grid comp when it is not land_assim #505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATED by @gmao-rreichle:
This PR fixes a problem reported by @gmao-qliu on 3 Jan 2022:
When GEOSldas v17.10.0 is used to write out L-band Tb data in a single-member simulation without perturbations and without data assimilation (ie, land_assim=no), the run crashes during MAPL_GenericInitialize() in the LandAssim GridComp (when the mwRTM parameters are read from the restart file). There is no crash when v17.10.0 is used in an ensemble data assimilation configuration.
The single-member, no assimilation configuration with Tb output is needed for the SMAP Nature Run (e.g., NR5000) that is delivered to the SMAP Project at JPL. The last tag for which this is known to work is v17.9.0-beta.8 (currently used for NR5000).
@saraqzhang Would you please verify this PR for me? The question here is if there exists such scenario that it is not land_assim but needs catchincr grid comp?